Skip to content

chore: replace next/legacy/image with next/image #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 28, 2022
Merged

chore: replace next/legacy/image with next/image #1722

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5e94a5
chore: removed unused import
nickytonline Oct 27, 2022
1de22f8
chore: removed broken image that was no longer broken from main image…
nickytonline Oct 27, 2022
ab989a5
test: add e2e test to test broken image error
nickytonline Oct 27, 2022
262f0c6
chore: fixed image import
nickytonline Oct 27, 2022
6da578a
test: updated test validating image config
nickytonline Oct 27, 2022
3d516e4
test: fixed broken image test
nickytonline Oct 27, 2022
dbd8558
test: fixed broken image test as it's different when deployed
nickytonline Oct 27, 2022
c865a9f
Merge branch 'main' into next-js-images
nickytonline Oct 28, 2022
5cf563d
test: used a real image to test an image not on the Next.js allow list
nickytonline Oct 28, 2022
9c2689c
Merge branch 'main' into next-js-images
nickytonline Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,11 @@ describe('onBuild()', () => {
expect(config.config.env.NEXTAUTH_URL).toEqual(mockUserDefinedSiteUrl)
})

test('sets the NEXTAUTH_URL to the DEPLOY_PRIME_URL when CONTEXT env variable is not \'production\'', async () => {
test("sets the NEXTAUTH_URL to the DEPLOY_PRIME_URL when CONTEXT env variable is not 'production'", async () => {
const mockUserDefinedSiteUrl = chance.url()
process.env.DEPLOY_PRIME_URL = mockUserDefinedSiteUrl
process.env.URL = chance.url()

// See https://docs.netlify.com/configure-builds/environment-variables/#build-metadata for all possible values
process.env.CONTEXT = 'deploy-preview'

Expand All @@ -277,8 +277,8 @@ describe('onBuild()', () => {

expect(config.config.env.NEXTAUTH_URL).toEqual(mockUserDefinedSiteUrl)
})
test('sets the NEXTAUTH_URL to the user defined site URL when CONTEXT env variable is \'production\'', async () => {

test("sets the NEXTAUTH_URL to the user defined site URL when CONTEXT env variable is 'production'", async () => {
const mockUserDefinedSiteUrl = chance.url()
process.env.DEPLOY_PRIME_URL = chance.url()
process.env.URL = mockUserDefinedSiteUrl
Expand All @@ -300,7 +300,6 @@ describe('onBuild()', () => {

expect(config.config.env.NEXTAUTH_URL).toEqual(mockUserDefinedSiteUrl)
})


test('sets the NEXTAUTH_URL specified in the netlify.toml or in the Netlify UI', async () => {
const mockSiteUrl = chance.url()
Expand Down Expand Up @@ -615,7 +614,7 @@ describe('onBuild()', () => {
const imageConfigPath = path.join(constants.INTERNAL_FUNCTIONS_SRC, IMAGE_FUNCTION_NAME, 'imageconfig.json')
const imageConfigJson = await readJson(imageConfigPath)

expect(imageConfigJson.domains.length).toBe(2)
expect(imageConfigJson.domains.length).toBe(1)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wikipedia domain was removed, so now there is only one domain. See https://github.com/netlify/next-runtime/pull/1722/files#diff-f3bc73930689da34c69d4dd219fb06b3965a303551a6b4fe527b2492534511e6L74

expect(imageConfigJson.remotePatterns.length).toBe(1)
expect(imageConfigJson.responseHeaders).toStrictEqual({
'X-Foo': mockHeaderValue,
Expand Down