feat: support Next 13 #1714

ascorbic · 2022-10-25T13:49:40Z

Summary

Updates the test sites and dependencies to Next 13 (actually 12.3.2-canary.43, but that is the same as next 13, which isn;t yet in npm)

Test plan

Check the deploy previews and e2e tests!

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality
Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

netlify · 2022-10-25T13:49:45Z

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63580df0c1f57e000820e20a
😎 Deploy Preview	https://deploy-preview-1714--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:49:46Z

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63580df0580f310009065409
😎 Deploy Preview	https://deploy-preview-1714--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:49:46Z

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63580df0a996eb0009959128
😎 Deploy Preview	https://deploy-preview-1714--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:49:46Z

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63580df01c8b370009fc3036
😎 Deploy Preview	https://deploy-preview-1714--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:50:27Z

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63580df069099f0009ccefe8
😎 Deploy Preview	https://deploy-preview-1714--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:50:57Z

❌ Deploy Preview for next-i18next-demo failed.

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/63580df09a01d500081d25c5

netlify · 2022-10-25T13:51:20Z

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63580df053afba0008519aa8
😎 Deploy Preview	https://deploy-preview-1714--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:51:39Z

✅ Deploy Preview for next-plugin-canary ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-canary/deploys/63580df053afba0008519aa4
😎 Deploy Preview	https://deploy-preview-1714--next-plugin-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-10-25T13:51:40Z

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`af713f6`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63580df0824e5d0008ceeff3
😎 Deploy Preview	https://deploy-preview-1714--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/runtime/src/templates/edge/runtime.ts

ascorbic · 2022-10-25T15:17:36Z

I've disabled Node 12 tests in branch protections. Once this is in we can start requiring the Node 14 tests instead

ascorbic · 2022-10-25T15:28:19Z

@ericapisani the next/image tests are failing at the moment. The images seem to display fine, but the tests fail. I'm going to switch them to use next/legacy/image and we can look into why the new component is breaking thing.

demos/default/pages/deep/import.js

ascorbic · 2022-10-25T15:45:09Z

The I18next site is failing because it doesn't like the canary version number. Updating to 13.0.0 should fix that.

nickytonline · 2022-10-25T15:58:55Z

demos/canary/pages/index.js

@@ -1,5 +1,5 @@
 import Head from 'next/head'
-import Image from 'next/image'
+import Image from 'next/legacy/image'


Is this temporary until the image tests get working in this PR or are we switching back to the new next/image post this PR?

I think we do it post this PR

nickytonline

The changes look good. Assuming all checks pass, this is good to 🚀

ascorbic · 2022-10-25T16:28:31Z

The i18next demo will fail to build for now (until Next 13 is published to npm), but aside from that it should all be good to go.

chore(deps): update demos and deps to Next 13

9a43a09

ascorbic requested a review from a team October 25, 2022 13:49

github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 25, 2022

chore: add swc

cfa5a46

ascorbic added 3 commits October 25, 2022 14:53

chore: switch old node tests to use node 14

aab3b80

fix: correct requestdata type

c310c57

chore: update next/link syntax

c02aed0

nickytonline reviewed Oct 25, 2022

View reviewed changes

packages/runtime/src/templates/edge/runtime.ts Show resolved Hide resolved

nickytonline reviewed Oct 25, 2022

View reviewed changes

demos/default/pages/deep/import.js Show resolved Hide resolved

nickytonline reviewed Oct 25, 2022

View reviewed changes

ascorbic changed the title ~~chore(deps): update demos and deps to Next 13~~ feat: support Next 13 Oct 25, 2022

github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 25, 2022

chore: use legacy image component for now

af713f6

ascorbic force-pushed the mk/next-13 branch from 04b536c to af713f6 Compare October 25, 2022 16:25

nickytonline approved these changes Oct 25, 2022

View reviewed changes

nickytonline mentioned this pull request Oct 25, 2022

fix: support appDir #1638

Merged

6 tasks

ascorbic added the automerge label Oct 25, 2022

kodiakhq bot merged commit efcb47a into main Oct 25, 2022

kodiakhq bot deleted the mk/next-13 branch October 25, 2022 16:34

token-generator-app bot mentioned this pull request Oct 25, 2022

chore: release main #1713

Merged

nickytonline mentioned this pull request Oct 26, 2022

Issues with next/image in Next.js 13 #1721

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support Next 13 #1714

feat: support Next 13 #1714

ascorbic commented Oct 25, 2022

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

ascorbic commented Oct 25, 2022

ascorbic commented Oct 25, 2022 •

edited

Loading

ascorbic commented Oct 25, 2022

nickytonline Oct 25, 2022

ascorbic Oct 25, 2022

nickytonline left a comment

ascorbic commented Oct 25, 2022

feat: support Next 13 #1714

feat: support Next 13 #1714

Conversation

ascorbic commented Oct 25, 2022

Summary

Test plan

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

netlify bot commented Oct 25, 2022 • edited Loading

❌ Deploy Preview for next-i18next-demo failed.

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for next-plugin-canary ready!

netlify bot commented Oct 25, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

ascorbic commented Oct 25, 2022

ascorbic commented Oct 25, 2022 • edited Loading

ascorbic commented Oct 25, 2022

nickytonline Oct 25, 2022

Choose a reason for hiding this comment

ascorbic Oct 25, 2022

Choose a reason for hiding this comment

nickytonline left a comment

Choose a reason for hiding this comment

ascorbic commented Oct 25, 2022

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

netlify bot commented Oct 25, 2022 •

edited

Loading

ascorbic commented Oct 25, 2022 •

edited

Loading