Skip to content

Use packageJson #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Use packageJson #17

merged 1 commit into from
Oct 29, 2020

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented Oct 29, 2020

This adds the new packageJson argument passed to plugin handlers, which helps simplifying code and handle any edge case (for example, the current code did not work when using a base directory with a package.json several directories above it).

Note: you will need to upgrade Netlify Build to 5.1.0 (the version is shown in build logs) to try this locally. Until we make a release of the CLI, in the repository which uses netlify-cli, this can be done by removing your package-lock.json and node_modules, then running npm install again. If installed globally, this can be done by re-installing netlify-cli globally.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 29, 2020
@ehmicky ehmicky requested a review from lindsaylevine October 29, 2020 19:58
@ehmicky ehmicky self-assigned this Oct 29, 2020
@lindsaylevine
Copy link

Fixes #15

Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for this!!!!!!!

@ehmicky ehmicky merged commit 8a48029 into main Oct 29, 2020
@ehmicky ehmicky deleted the feat/use-packagejson branch October 29, 2020 20:10
ascorbic added a commit that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants