Skip to content

fix: gracefully handle missing static analysis tools #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

ascorbic
Copy link
Contributor

Summary

With the changes to one function per API route, we try to use static analysis to extract the config. However these tools were only added in Next 12.2, and we weren't handling the case where they are missing. This PR ensures that we gracefully handle the missing modules.

Fixes #1690

@ascorbic ascorbic requested a review from a team October 18, 2022 08:43
@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/634e673ebedf07000927801f
😎 Deploy Preview https://deploy-preview-1691--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/634e673ea4296600083a63d0
😎 Deploy Preview https://deploy-preview-1691--next-plugin-rsc-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 18, 2022
@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/634e673efe935600096affef
😎 Deploy Preview https://deploy-preview-1691--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/634e673e3e6ea30008d99cca
😎 Deploy Preview https://deploy-preview-1691--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/634e673e785c2e0009cda91d
😎 Deploy Preview https://deploy-preview-1691--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/634e673e2560c10007e6abac
😎 Deploy Preview https://deploy-preview-1691--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/634e673efe935600096afff4
😎 Deploy Preview https://deploy-preview-1691--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/634e673e6cca3a0008a869c9
😎 Deploy Preview https://deploy-preview-1691--next-plugin-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/634e673e6cca3a0008a869c4
😎 Deploy Preview https://deploy-preview-1691--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 0c1dcec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/634e673e353b370008db44e5
😎 Deploy Preview https://deploy-preview-1691--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ascorbic!

@kodiakhq kodiakhq bot merged commit 34a039e into main Oct 18, 2022
@kodiakhq kodiakhq bot deleted the mk/old-next-analysis branch October 18, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot find module 'next/dist/build/analysis/extract-const-value'
2 participants