fix: use process.env.URL when deploying to production #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericapisani
added
the
type: chore
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for next-i18next-demo failed.
|
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ep-next-auth ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ericapisani
changed the title
ericapisani
removed
the
type: chore
Closed
2 tasks
Closed
2 tasks
nickytonline
previously approved these changes
Oct 25, 2022
Co-authored-by: Nick Taylor <[email protected]>
nickytonline
previously approved these changes
Oct 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
next-authto the latestNEXTAUTH_URL.next-authuses that URL as the basis for updating it's provider information. For instance - the callback URL used for OAuth applications (since it expects a stable value). This change makes the URL stable by using the 'URL' rather than theDEPLOY_PRIME_URLwhen it detects that theCONTEXTis set to 'production'Test plan
/adminor/me, the URL that it goes to should be the URL of the site (e.g:https://deploy-preview-1680--netlify-plugin-nextjs-next-auth-demo.netlify.app/api/callback....)/adminand/mepages/adminor/me, the URL that it goes to should start withhttps://ep-next-auth.netlify.app/nothttps://upgrade-next-auth--ep-next-auth.netlify.app/meendpoint, but the/adminpage should still be inaccessible sinceuserRole: adminis not set on the returned token that makes that page accessible.