feat: add support for WebAssembly in edge runtime #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ascorbic
changed the title
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nickytonline
previously approved these changes
Oct 17, 2022
Comment on lines
+621
to
+626
| // We need to pretend there's no edge API routes, because otherwise it'll fail | ||
| // when we try to disable edge runtime. | ||
| const manifest = path.join('.next', 'server', 'middleware-manifest.json') | ||
| const manifestContent = await readJson(manifest) | ||
| manifestContent.functions = {} | ||
| await writeJSON(manifest, manifestContent) |
There was a problem hiding this comment.
This doesn't block the PR, but could we not have a separate test for the scenario when NEXT_DISABLE_NETLIFY_EDGE=1 and we have routes, that we expect it to throw? Or maybe I'm misunderstanding the error being explained here.
| const { searchParams } = req.nextUrl | ||
| const username = searchParams.get('username') | ||
|
|
||
| return new ImageResponse( |
There was a problem hiding this comment.
For context where this component is coming from, see the Vercel example, https://vercel.com/docs/concepts/functions/edge-functions/og-image-generation#getting-started
ascorbic
force-pushed
the
mk/wasm-support
branch
from
85ca8f5 to
22da599
Compare
ascorbic
force-pushed
the
mk/wasm-support
branch
from
22da599 to
6cb97a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for wasm in the edge runtime. When Next.js builds a site that uses wasm in the edge runtime, it emits the wasm files into the
.next/server/edge-chunksdirectory. The runtime expects these chunks to be available as arraybuffers as variables, named according to the chunk name. We do this by inlining them as base64-encoded strings, then wrapping those indecode()calls (using the Deno base64 lib).Similarly, static assets such as fonts are replaced with
blob:URLs, which use the chunk name for the path. We handle this in the same way as the Next edge runtime: by wrappingfetchand intercepting any calls that request a blob URI, returning the base64-encoded file in a Response instead.This PR also adds the OG image lib to the default demo, and uses it for an e2e test.
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.