Skip to content

feat: use display names for edge functions #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Oct 7, 2022

Summary

Edge functions now support display names. This PR adds support for these. Aside from the ipx and dev edge funcitons, these just use the name from Next.js, which is the path.

Test plan

  1. Visit a deploy that uses edge functions (e.g. this one with middleware or this one with server components
  2. View the edge function logs
  3. Observe that the list of functions in the filter uses display names (e.g. middleware, next/image handler)

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from a team October 7, 2022 10:51
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 2b786e4
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/634004bb2d68370008bedee9
😎 Deploy Preview https://deploy-preview-1669--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63496a2e4aa90500082785f4
😎 Deploy Preview https://deploy-preview-1669--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63496a2e8c3d450009a76e0f
😎 Deploy Preview https://deploy-preview-1669--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63496a2e0e9319000a33a552
😎 Deploy Preview https://deploy-preview-1669--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63496a2e12e8f300082ec63d
😎 Deploy Preview https://deploy-preview-1669--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/63496a2e9b60aa0009762881
😎 Deploy Preview https://deploy-preview-1669--next-plugin-rsc-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 7, 2022
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63496a2ead3f1700099d6fdd
😎 Deploy Preview https://deploy-preview-1669--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63496a2e68efa10009fc9c3c
😎 Deploy Preview https://deploy-preview-1669--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63496a2e05cbad000856f36b
😎 Deploy Preview https://deploy-preview-1669--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63496a2ecca45b0008e32171
😎 Deploy Preview https://deploy-preview-1669--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit c370867
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/63496a2eaa196b0008d243be
😎 Deploy Preview https://deploy-preview-1669--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :D

@kodiakhq kodiakhq bot merged commit 310292a into main Oct 14, 2022
@kodiakhq kodiakhq bot deleted the mk/edge-display-name branch October 14, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants