feat: Add ability to disable ipx #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes some domain path and test updates
when ipx is removed, need to use sharp for image optimization
ensure basePath redirect is still added
don't add ipx function to netlifyConfig if ipx is disabled
also do general cleanup
ericapisani
added
the
type: feature
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ep-disable-ipx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ascorbic
reviewed
Oct 3, 2022
ascorbic
reviewed
Oct 3, 2022
| if (destr(process.env.DISABLE_IPX)) { | ||
| // If no image loader is specified, need to redirect to a 404 page since there's no | ||
| // backing loader to serve local site images once deployed to Netlify | ||
| if (!IS_LOCAL && imageconfig.loader && imageconfig.loader === 'default') { |
There was a problem hiding this comment.
[sand] does this need the check for imageconfig.loader?
There was a problem hiding this comment.
No, I had written that out of habit when a property is optional, but this could be achieved with the imageconfig.loader === 'default' check
ascorbic
previously approved these changes
Oct 3, 2022
sarahetter
approved these changes
Oct 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows for the ability to disable
ipxvia theDISABLE_IPXenvironment variable.If this is enabled, this will require users to a loader (such as Cloudinary), otherwise the images that would've previously been served by
ipxwill return a 404.Test plan
Deploy preview - https://ep-disable-ipx.netlify.app
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1605
Related documentation PR: https://github.com/netlify/docs/pull/2414
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.