chore: standardise ODB terminology #1641
Conversation
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for next-plugin-app-dir failed.
|
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -25,7 +25,7 @@ export async function getStaticProps(context) { | |||
| props: { | |||
| show: data, | |||
| }, | |||
| revalidate: 1, | |||
| revalidate: 60, | |||
There was a problem hiding this comment.
A comment linking to documentation about the 60 second minimum would be helpful for folks navigating through the codebase.
There was a problem hiding this comment.
I popped a note in the readme because there are various different demo pages with revalidate: 60 and thought it best not to duplicate the comment everywhere
There was a problem hiding this comment.
I think this may have been deliberately set to 1 to check that it's correctly being changed to 60.
There was a problem hiding this comment.
@ascorbic ah, i see - i'll change it back and add a comment
| ) | ||
| multiValueHeaders['x-nf-render-mode'] = [requestMode] | ||
|
|
||
| console.log(`[${event.httpMethod}] ${event.path} (${requestMode?.toUpperCase()})`) |
There was a problem hiding this comment.
Was this console.log added for debugging purposes and accidentally added?
There was a problem hiding this comment.
Thanks but nope - this is by design so that the ODB request is logged in the function logs
Summary
As discussed internally, we are currently mixing terminology by referring to non-prerendered dynamic routes as 'ODB' and pre-rendered routes with revalidate as 'ISR'.
This PR standardises our header values and log output to use Netlify terminology: 'ODB' or 'ODB ttl=60'
Test plan
See updated Cypress tests
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal