Skip to content

fix: add missing data to middleware request object #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 28, 2022
Merged

fix: add missing data to middleware request object #1634

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
930e809
fix: add missing data to middleware request object
ericapisani Sep 22, 2022
b8fdb1d
docs: add limitations of edge middleware in local dev
ericapisani Sep 23, 2022
d8c55af
Merge branch 'main' into ep-inconsistent-edge-func-behaviour
ericapisani Sep 23, 2022
6dac0ae
test: add test coverage for MiddlewareRequest
ericapisani Sep 23, 2022
5d7027d
fix: revert the change I made to focus on a test file
ericapisani Sep 23, 2022
154bff2
test: remove some of the hard coded strings
ericapisani Sep 23, 2022
d925520
Merge branch 'main' into ep-inconsistent-edge-func-behaviour
ericapisani Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ Next.js Middleware works out of the box on Netlify. By default, middleware runs
support for running Middleware at the origin, set the environment variable `NEXT_DISABLE_NETLIFY_EDGE` to `true`. Be
aware that this will result in slower performance, as all pages that match middleware must use SSR.

### Limitations

Due to how the site configuration is handled when it's run using Netlify Edge Functions, data such as `locale` and `defaultLocale` will be missing on the `req.nextUrl` object when running `netlify dev`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "such as", does that mean there are other things missing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet done an audit of all the properties that are affected by this so I'm not 100% certain that these are the only properties affected on the nextUrl object.

Something to add here as well but the pathname (as reported by the user who originally raised this issue with us) was also incorrect before these changes and should be mentioned.


However, this data is available on `req.nextUrl` in a production environment.

## Monorepos

If you are using a monorepo you will need to change `publish` to point to the full path to the built `.next` directory,
Expand Down