feat: add support for Next 12.3 middleware matchers #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+214
to
+215
| value = value | ||
| .replace(/(:|\*|\?|\+|\(|\)|\{|\})/g, '\\$1') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.
|
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for next-plugin-rsc-demo failed.
|
ascorbic
force-pushed
the
mk/middleware-matcher
branch
3 times, most recently
from
2452624 to
dde04aa
Compare
ascorbic
force-pushed
the
mk/middleware-matcher
branch
from
dde04aa to
f0fb695
Compare
ascorbic
commented
Sep 9, 2022
| @@ -83,7 +83,7 @@ export const buildResponse = async ({ | |||
| const transformed = response.dataTransforms.reduce((prev, transform) => { | |||
| return transform(prev) | |||
| }, props) | |||
| return context.json(transformed) | |||
| return new Response(JSON.stringify(transformed), response) | |||
There was a problem hiding this comment.
This is because of https://github.com/netlify/edge-functions-bootstrap/pull/76
ascorbic
commented
Sep 9, 2022
| @@ -9,7 +9,7 @@ | |||
| "lint": "next lint" | |||
| }, | |||
| "dependencies": { | |||
| "next": "^12.2.6-canary.12", | |||
| "next": "^12.2.0", | |||
There was a problem hiding this comment.
I've temporarily set this to the old version so we can test backward-compat
orinokai
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Code looks sound, but did run into a couple of issues following the test plan:
- When requesting the data route (with or without the request header) I got the
x-is-denoheader, but not thex-middleware-nextheader (but I'm wondering if that's normal for a data route?). - Very strangely, when I first tested the middleware demo (deployed to Netlify) and hit the first link on the page,
/shows/rewriteme, the middleware didn't run and I got 'This should have been rewritten', instead of the/shows/100content. However, I can't reproduce this again (I've tried re-deploying a couple of times).
So... assuming the above 2 issues are, in fact, non-issues, then it's good to go.
|
@orinokai 🤦🏻♂️ I meant |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for 12.3 middleware matchers, including
hasandlocalesupport.Test plan
x-middleware-nextandx-is-denoare not setx-my-headertomy-value. Check that headersx-middleware-nextandx-is-denoare setx-middleware-nextandx-is-denoare set.Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1602. FIxes #1481. Fixes https://github.com/netlify/pod-ecosystem-frameworks/issues/230
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.