Skip to content

feat: support updated remotePatterns configuration #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

ericapisani
Copy link

@ericapisani ericapisani commented Sep 8, 2022

Summary

Supports both the use of remotePatterns under both the experimental property and within the images property (in v12.3 of next)

Test plan

  1. Visit the Deploy Preview - https://deploy-preview-1607--next-plugin-canary.netlify.app/

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Fixes #1601

PXL_20220908_143255053

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 8, 2022
@ericapisani ericapisani self-assigned this Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/631a2b3c7af15d0008deeeec
😎 Deploy Preview https://deploy-preview-1607--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/631a2b3cf2f0910008e43acc
😎 Deploy Preview https://deploy-preview-1607--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/631a2b3c85d2470008921c14

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/631a2b3c5ec68800088f9417
😎 Deploy Preview https://deploy-preview-1607--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/631a2b3c4c656f0009e0ecc5
😎 Deploy Preview https://deploy-preview-1607--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/631a2b3c5e3cf100081cb12f
😎 Deploy Preview https://deploy-preview-1607--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/631a2b3ccb60d50008dce79b
😎 Deploy Preview https://deploy-preview-1607--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/631a2b3c84119500094089a6
😎 Deploy Preview https://deploy-preview-1607--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/631a2b3ce53aca0009132e7e
😎 Deploy Preview https://deploy-preview-1607--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/631a2b3ce37647000ac5364c
😎 Deploy Preview https://deploy-preview-1607--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit f1596c3
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/631a2b3ccb60d50008dce7a0
😎 Deploy Preview https://deploy-preview-1607--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ericapisani ericapisani marked this pull request as ready for review September 8, 2022 17:42
@ericapisani ericapisani requested a review from a team September 8, 2022 17:42
@ericapisani ericapisani marked this pull request as draft September 8, 2022 17:45
@ericapisani ericapisani marked this pull request as ready for review September 8, 2022 17:50
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍🏻

@kodiakhq kodiakhq bot merged commit e7bed15 into main Sep 8, 2022
@kodiakhq kodiakhq bot deleted the ep-support-stable-remote-pattern branch September 8, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stable remotePattern option
2 participants