Skip to content

fix: handle stricter Next type #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: handle stricter Next type #1597

merged 2 commits into from
Sep 7, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Sep 6, 2022

Summary

A small change to Next types broke our builds in canary. Changing from an interface to type fixes it.

@ascorbic ascorbic requested a review from a team September 6, 2022 14:54
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/63186a8d4d2db60008247578
😎 Deploy Preview https://deploy-preview-1597--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63186a8d5feb8300093bb4e6
😎 Deploy Preview https://deploy-preview-1597--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63186a8d27576400084e76b2

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63186a8d3ba93a00087d3054
😎 Deploy Preview https://deploy-preview-1597--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Sep 6, 2022
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/63186a8de68e810008592ea8
😎 Deploy Preview https://deploy-preview-1597--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63186a8d3d8b9400080a2c57
😎 Deploy Preview https://deploy-preview-1597--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63186a8dca81820009e48f2f
😎 Deploy Preview https://deploy-preview-1597--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63186a8dd1198e0009d8efac
😎 Deploy Preview https://deploy-preview-1597--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/63186a8d7e645200087d764f
😎 Deploy Preview https://deploy-preview-1597--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63186a8d50e0860008fa786c
😎 Deploy Preview https://deploy-preview-1597--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 96335d0
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63186a8d27576400084e76b7
😎 Deploy Preview https://deploy-preview-1597--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 368ab3c into main Sep 7, 2022
@kodiakhq kodiakhq bot deleted the mk/extends-type branch September 7, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants