Skip to content

chore: fix broken next-auth demo #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

chore: fix broken next-auth demo #1551

merged 1 commit into from
Aug 18, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Aug 18, 2022

Summary

Update demo from React 17, which broke builds. Also changes tests to run with Node LTS (16) because Node 18 was causing engines issues.

Test plan

  1. Check the next-auth demo preview builds

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from a team August 18, 2022 06:13
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 18, 2022
@ascorbic ascorbic changed the base branch from mk/revert-runtime-refs to main August 18, 2022 06:14
@ascorbic ascorbic force-pushed the mk/simplify-auth-demo branch from 2dd6555 to 4fe787f Compare August 18, 2022 06:15
@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62fdef8e2855950008eeb92b
😎 Deploy Preview https://deploy-preview-1551--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62fdef8e189ffe0008b96d8a
😎 Deploy Preview https://deploy-preview-1551--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62fdef8eb41379000856ee5b
😎 Deploy Preview https://deploy-preview-1551--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62fdef8e2855950008eeb926
😎 Deploy Preview https://deploy-preview-1551--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62fdef8e2597ef0008550cd0
😎 Deploy Preview https://deploy-preview-1551--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62fdef8e7f8ab00008ab4805
😎 Deploy Preview https://deploy-preview-1551--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62fdef8eb41379000856ee60
😎 Deploy Preview https://deploy-preview-1551--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62fdef8ea6f8650009a22253
😎 Deploy Preview https://deploy-preview-1551--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62fdef8e3536ac0009abe703
😎 Deploy Preview https://deploy-preview-1551--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62fdef8e2597ef0008550cd5
😎 Deploy Preview https://deploy-preview-1551--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 5604d34
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62fdef8ea6f8650009a22258
😎 Deploy Preview https://deploy-preview-1551--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic force-pushed the mk/simplify-auth-demo branch from 319f87b to c5bff98 Compare August 18, 2022 07:36
@ascorbic ascorbic changed the title chore: remove unused pages from demo chore: fix broken next-auth demo Aug 18, 2022
@ascorbic ascorbic force-pushed the mk/simplify-auth-demo branch from ad8867e to 5604d34 Compare August 18, 2022 07:51
Copy link

@estephinson estephinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import "./styles.css"

// Use of the <SessionProvider> is mandatory to allow components that call
// `useSession()` anywhere in your application to access the `session` object.
export default function App({ Component, pageProps }: AppProps) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big sads the props are gone, any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something weird with Next types that are not important to fix today!

@kodiakhq kodiakhq bot merged commit f6269e9 into main Aug 18, 2022
@kodiakhq kodiakhq bot deleted the mk/simplify-auth-demo branch August 18, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants