Skip to content

chore: revert runtime dep name in demos #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

ascorbic
Copy link
Contributor

Summary

We've backed-out the runtime name. This reverts the dependencies in the demos.

Test plan

  1. Ensure all demo sites build

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

capy and guinea

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic requested a review from a team August 18, 2022 06:00
@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62fdffb74690be0009a2f845
😎 Deploy Preview https://deploy-preview-1550--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62fdffb74690be0009a2f84a
😎 Deploy Preview https://deploy-preview-1550--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62fdffb768d5050009082c74
😎 Deploy Preview https://deploy-preview-1550--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62fdffb80b0da0000a08b27f
😎 Deploy Preview https://deploy-preview-1550--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Aug 18, 2022
@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62fdffb71191670008f9a270
😎 Deploy Preview https://deploy-preview-1550--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62fdffb8d32d6600089f0650
😎 Deploy Preview https://deploy-preview-1550--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62fdffb70ca1b00008b32f65
😎 Deploy Preview https://deploy-preview-1550--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62fdffb70f5dd9000842e0b8
😎 Deploy Preview https://deploy-preview-1550--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62fdffb82855950008f205a1
😎 Deploy Preview https://deploy-preview-1550--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62fdffb839e45c00081c9c91
😎 Deploy Preview https://deploy-preview-1550--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit d268450
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62fdffb8f9e47a0009ae4f0a
😎 Deploy Preview https://deploy-preview-1550--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic force-pushed the mk/revert-runtime-refs branch from 5de530c to 11f210e Compare August 18, 2022 08:57
@ascorbic ascorbic force-pushed the mk/revert-runtime-refs branch from 11f210e to d268450 Compare August 18, 2022 09:00
Copy link

@estephinson estephinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit ba27564 into main Aug 18, 2022
@kodiakhq kodiakhq bot deleted the mk/revert-runtime-refs branch August 18, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants