feat(graph): populate graph token for ISR #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 5 commits into main from dww/graph-token

Aug 14, 2022

dwwoelfel commented Aug 12, 2022

Summary

Allows the getSecretsForBuild and getNetlifyGraphTokenForBuild functionality to work with ISR in next.js.

Populates an environment variable that graph helpers exported from @netlify/functions will be able to read.

Test plan

Here is an example of it in action: https://bucolic-torte-c9a71a.netlify.app/posts/15
Corresponding code: https://github.com/dwwoelfel/nextjs-blog-theme-9/blob/main/pages/posts/%5Bslug%5D.js#L17

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality
Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

dwwoelfel added 2 commits

August 12, 2022 11:42


          feat(graph): populate graph token in odb

03c43aa


          feat(graph): simplify

daa0d3c

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-hp-edge-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/next-hp-edge-demo/deploys/62f6dd74da8db30008a9bbb4
😎 Deploy Preview	https://deploy-preview-1525--next-hp-edge-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62f6dd74e377ab00084ef9fa
😎 Deploy Preview	https://deploy-preview-1525--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62f6dd74fda8da0008779b89
😎 Deploy Preview	https://deploy-preview-1525--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62f6dd74b6c0a30008abe514
😎 Deploy Preview	https://deploy-preview-1525--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions bot added the type: feature label

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62f6dd74489dcc0008146525
😎 Deploy Preview	https://deploy-preview-1525--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62f6dd749965e90009401386
😎 Deploy Preview	https://deploy-preview-1525--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62f6dd7417f2ec00080313a6
😎 Deploy Preview	https://deploy-preview-1525--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62f6dd74fcb8b60009c1aafe
😎 Deploy Preview	https://deploy-preview-1525--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-canary ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-canary/deploys/62f6dd74a446cf0008f328a5
😎 Deploy Preview	https://deploy-preview-1525--next-plugin-canary.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for next-i18next-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/62f6dd749965e9000940138d
😎 Deploy Preview	https://deploy-preview-1525--next-i18next-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Aug 12, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`271eaff`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62f6dd749cac3400084e2958
😎 Deploy Preview	https://deploy-preview-1525--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dwwoelfel mentioned this pull request

feat(graph): update graph helpers to work better with next.js netlify/functions#354

Merged

ascorbic reviewed

View reviewed changes

packages/runtime/src/templates/getHandler.ts Outdated Show resolved Hide resolved

dwwoelfel added 3 commits

August 12, 2022 15:07


          chore(graph): set env var before the launcher

ba65a56


          chore(graph): update functions dep

f555f46


          undo whitespace change

271eaff

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

7 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-static-demo
Status	Passed
Commit	`6b00d09` ℹ️
Started	Aug 12, 2022 11:12 PM
Ended	Aug 12, 2022 11:13 PM
Duration	01:23 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

22 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-default-demo
Status	Passed
Commit	`6b00d09` ℹ️
Started	Aug 12, 2022 11:12 PM
Ended	Aug 12, 2022 11:13 PM
Duration	01:33 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Aug 12, 2022 •

edited

Loading

Test summary

2 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-nx-monorepo-demo
Status	Passed
Commit	`6b00d09` ℹ️
Started	Aug 12, 2022 11:13 PM
Ended	Aug 12, 2022 11:14 PM
Duration	01:11 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 104

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

dwwoelfel marked this pull request as ready for review

August 12, 2022 23:16

dwwoelfel requested a review from a team

August 12, 2022 23:16

ascorbic approved these changes

View reviewed changes

Contributor

ascorbic left a comment

dwwoelfel added the automerge label

kodiakhq bot merged commit 573b913 into main

kodiakhq bot deleted the dww/graph-token branch

August 14, 2022 23:14

This was referenced Aug 14, 2022

chore: release main #1523

Merged

chore: release main #1539

Merged

token-generator-app bot mentioned this pull request

chore: release main #1549

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: feature