Skip to content

fix: allow proxy of /_next/static #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022
Merged

fix: allow proxy of /_next/static #1503

merged 2 commits into from
Aug 10, 2022

Conversation

hs-netlify
Copy link

Summary

The next plugin doesn't proxy /_next/static/ when request as it gets dropped. This stops chunks from loading when proxied to a different Next.js site.

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@hs-netlify hs-netlify self-assigned this Aug 4, 2022
@hs-netlify hs-netlify requested a review from a team August 4, 2022 09:19
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62f3d3206704b4000879278b
😎 Deploy Preview https://deploy-preview-1503--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62f3d321bf66050009dcce8b
😎 Deploy Preview https://deploy-preview-1503--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62f3d320a4c44a000899844a
😎 Deploy Preview https://deploy-preview-1503--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Aug 4, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62f3d3200405f000079a384c
😎 Deploy Preview https://deploy-preview-1503--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62f3d320a4c44a000899844f
😎 Deploy Preview https://deploy-preview-1503--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62f3d320a5c8b50009a4b31c
😎 Deploy Preview https://deploy-preview-1503--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62f3d320d1c90500086d05db
😎 Deploy Preview https://deploy-preview-1503--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62f3d321a5c8b50009a4b321
😎 Deploy Preview https://deploy-preview-1503--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62f3d32082aab800086fe162
😎 Deploy Preview https://deploy-preview-1503--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62f3d320bdc32c000a444446
😎 Deploy Preview https://deploy-preview-1503--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit be91a56
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62f3d320f47e9f0008948ea7
😎 Deploy Preview https://deploy-preview-1503--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Aug 4, 2022



Test summary

22 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 500a7f3 ℹ️
Started Aug 10, 2022 3:51 PM
Ended Aug 10, 2022 3:53 PM
Duration 01:24 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 4, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 500a7f3 ℹ️
Started Aug 10, 2022 3:51 PM
Ended Aug 10, 2022 3:52 PM
Duration 01:15 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 4, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 500a7f3 ℹ️
Started Aug 10, 2022 3:51 PM
Ended Aug 10, 2022 3:53 PM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @hs-netlify! 🚀

@hs-netlify hs-netlify merged commit 4efef60 into main Aug 10, 2022
@hs-netlify hs-netlify deleted the fix/next-static-proxy branch August 10, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants