Skip to content

fix: replace netlify:edge identifier with full URL #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

khendrikse
Copy link

@khendrikse khendrikse commented Aug 2, 2022

Summary

This replaces netlify:edge with https://edge.netlify.com.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Part of https://github.com/netlify/pillar-runtime/issues/322.

cute pug playing a guitar

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@khendrikse khendrikse added the type: chore work needed to keep the product and development running smoothly label Aug 2, 2022
@khendrikse khendrikse requested a review from a team August 2, 2022 15:31
@khendrikse khendrikse self-assigned this Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62e97c022adac90009f61b52
😎 Deploy Preview https://deploy-preview-1500--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62e97c0162986500095c7b51
😎 Deploy Preview https://deploy-preview-1500--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62e97c022acf250009a51b08
😎 Deploy Preview https://deploy-preview-1500--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62e97c022acf250009a51b03
😎 Deploy Preview https://deploy-preview-1500--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62e97c02eaff7e000806e112
😎 Deploy Preview https://deploy-preview-1500--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62e97c0278a8020008878833
😎 Deploy Preview https://deploy-preview-1500--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62e97c02a640ea000a52be67
😎 Deploy Preview https://deploy-preview-1500--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62e97c021078bd0008d00fe9
😎 Deploy Preview https://deploy-preview-1500--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62e97c0262986500095c7b56
😎 Deploy Preview https://deploy-preview-1500--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62e97c022952320008446575
😎 Deploy Preview https://deploy-preview-1500--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 23db3ec
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/62e97c02bb40310009ec763b
😎 Deploy Preview https://deploy-preview-1500--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Aug 2, 2022



Test summary

22 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 3c99ce0 ℹ️
Started Aug 2, 2022 7:36 PM
Ended Aug 2, 2022 7:37 PM
Duration 01:29 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 2, 2022



Test summary

0 7 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Failed
Commit bbeccb5 ℹ️
Started Aug 2, 2022 7:30 PM
Ended Aug 2, 2022 7:32 PM
Duration 01:40 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


Failures

i18n.spec.ts Failed
1 Localization > should use sub routing to determine current locale
2 Localization > should use the NEXT_LOCALE cookie to determine the default locale
3 Localization > should use the nf_lang cookie to determine the default locale
4 Localization > should use Accept-Language to choose a locale
5 Localization > should use the NEXT_LOCALE cookie over Accept-Language header to determine the default locale
rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
2 Rewrites and Redirects > redirects: redirects /redirectme to /

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Aug 2, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 3c99ce0 ℹ️
Started Aug 2, 2022 8:05 PM
Ended Aug 2, 2022 8:06 PM
Duration 01:40 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@khendrikse khendrikse removed the type: chore work needed to keep the product and development running smoothly label Aug 2, 2022
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, but let's wait for a 👍🏻 from the frameworks peeps.

Copy link

@ericapisani ericapisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thanks for making this change, will be happy to have to do less IDE wrangling to get this to compile going forward 😄

@nickytonline
Copy link

Just looking into why a bunch of checks are failing.

@nickytonline nickytonline force-pushed the fix/322/replace-netlify-edge-identifier-with-full-URL branch 2 times, most recently from f0d011d to 23db3ec Compare August 2, 2022 19:33
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I got all the checks to pass finally! 🚀

@khendrikse
Copy link
Author

Alright, I got all the checks to pass finally! 🚀

Thanks for looking at that @nickytonline 🙏

@khendrikse khendrikse merged commit 69327e6 into main Aug 3, 2022
@khendrikse khendrikse deleted the fix/322/replace-netlify-edge-identifier-with-full-URL branch August 3, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants