fix: include css files in handler functions #1463
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I'm not sure we want to include all CSS in every bundle. I think what we can do is check the |
|
@ascorbic ah ok, I didn't realize, thank you! I think it was just a function of working with the smaller test projects leading me to an incorrect assumption because I was seeing a 1:1 between what was listed in the Can make the changes to make it more selective 👍🏻 |
|
Ah woops, didn't read comments above before approving! |
Rather than use a glob pattern to add CSS files to the handler function, explicitly add the same file names listed in required-server-files.json under the "files" key Update the demos/default project in order to test this functionality
Summary
Includes css files in generated handler functions
Test plan
<head>tag<style>tag is presentSite showing broken behaviour here, where the
<style>tag is missingRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1268
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.