Skip to content

feat: get client IP from Context object rather than header #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

feat: get client IP from Context object rather than header #1460

merged 2 commits into from
Jul 12, 2022

Conversation

ericapisani
Copy link

Summary

Gets the client IP address from the Context object rather than the header.

@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 12, 2022
@ericapisani ericapisani self-assigned this Jul 12, 2022
@ericapisani ericapisani requested a review from a team July 12, 2022 12:34
@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62cd6cc8a70ab500089d180a
😎 Deploy Preview https://deploy-preview-1460--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62cd6cc85a90410009edfe5c
😎 Deploy Preview https://deploy-preview-1460--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62cd6cc8f4d2fc0009022605
😎 Deploy Preview https://deploy-preview-1460--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62cd6cc818957e0008ce88b5
😎 Deploy Preview https://deploy-preview-1460--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62cd6cc8a70ab500089d1805
😎 Deploy Preview https://deploy-preview-1460--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62cd6cc8f4d2fc000902260a
😎 Deploy Preview https://deploy-preview-1460--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62cd6cc8e742df0009c515ff
😎 Deploy Preview https://deploy-preview-1460--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62cd6cc884572700086abc9a
😎 Deploy Preview https://deploy-preview-1460--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62cd6cc890733b0007ee855f
😎 Deploy Preview https://deploy-preview-1460--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 96cf178
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62cd6cc83216940008ce5c52
😎 Deploy Preview https://deploy-preview-1460--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Jul 12, 2022 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit c3e856f ℹ️
Started Jul 12, 2022 12:49 PM
Ended Jul 12, 2022 12:51 PM
Duration 01:30 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 12, 2022 •
edited
Loading


Test summary

22 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit c3e856f ℹ️
Started Jul 12, 2022 12:50 PM
Ended Jul 12, 2022 12:51 PM
Duration 01:35 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 12, 2022 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit c3e856f ℹ️
Started Jul 12, 2022 12:49 PM
Ended Jul 12, 2022 12:50 PM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

nickytonline
nickytonline approved these changes Jul 12, 2022
View reviewed changes
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change! 🚀

@kodiakhq kodiakhq bot merged commit 30b6717 into main Jul 12, 2022
@kodiakhq kodiakhq bot deleted the ep/implement-client-ip-through-context-obj branch July 12, 2022 12:59
@token-generator-app token-generator-app bot mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

Assignees

@ericapisani ericapisani

Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericapisani @nickytonline