Skip to content

feat: Update next-auth middleware #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2022
Merged

feat: Update next-auth middleware #1432

merged 3 commits into from
Jun 29, 2022

Conversation

sarahetter
Copy link

@sarahetter sarahetter commented Jun 29, 2022 •
edited
Loading

Summary

Removes nested middleware for root level middleware, and updates both next and next-auth

Test plan

  1. Follow instructions at https://github.com/netlify/netlify-plugin-nextjs/blob/main/demos/next-auth/README.md
  2. run openssl rand -base64 32 and add the secret to an environment variable NEXTAUTH_SECRET
  3. run dev environment with npm run dev

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Closes #1430

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality - doesn't work without env var's set
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@sarahetter sarahetter requested a review from a team June 29, 2022 15:31
@sarahetter sarahetter self-assigned this Jun 29, 2022
@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62bc73cf6190fd00093913a4
😎 Deploy Preview https://deploy-preview-1432--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62bc73cf45be46000870737e
😎 Deploy Preview https://deploy-preview-1432--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62bc73cf35eddc0009e30ebc
😎 Deploy Preview https://deploy-preview-1432--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62bc73cfb915350009f46de3
😎 Deploy Preview https://deploy-preview-1432--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62bc73cf601c5b0009362bf6
😎 Deploy Preview https://deploy-preview-1432--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62bc73cf5feb760008bcff80
😎 Deploy Preview https://deploy-preview-1432--next-plugin-rsc-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62bc73cfef54280008d90fd9
😎 Deploy Preview https://deploy-preview-1432--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62bc73cfef54280008d90fdb
😎 Deploy Preview https://deploy-preview-1432--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 29, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit e0bc116
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62bc73cf35eddc0009e30ec1
😎 Deploy Preview https://deploy-preview-1432--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jun 29, 2022
@cypress
Copy link

cypress bot commented Jun 29, 2022 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit ec62726 ℹ️
Started Jun 29, 2022 3:51 PM
Ended Jun 29, 2022 3:52 PM
Duration 01:20 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 29, 2022 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit ec62726 ℹ️
Started Jun 29, 2022 3:51 PM
Ended Jun 29, 2022 3:53 PM
Duration 01:25 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 29, 2022 •
edited
Loading


Test summary

20 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit ec62726 ℹ️
Started Jun 29, 2022 3:51 PM
Ended Jun 29, 2022 3:52 PM
Duration 01:26 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

nickytonline
nickytonline approved these changes Jun 29, 2022
View reviewed changes
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed in and works as expected!

CleanShot.2022-06-29.at.11.52.44.mp4

@kodiakhq kodiakhq bot merged commit bd7887b into main Jun 29, 2022
@kodiakhq kodiakhq bot deleted the next-auth-middleware branch June 29, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

Assignees

@sarahetter sarahetter

Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Next Auth demo for root level middleware
2 participants
@sarahetter @nickytonline