Skip to content

chore: add codeowners and fixing pull request template #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

sarahetter
Copy link

Summary

Adds @netlify/frameworks as codeowner, and changes the pull request template to mention frameworks instead of integrations

@sarahetter sarahetter requested a review from a team June 9, 2022 20:05
@sarahetter sarahetter self-assigned this Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62a74065ed7f740008ddd987
😎 Deploy Preview https://deploy-preview-1376--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62a74065eda9c10007063f7c
😎 Deploy Preview https://deploy-preview-1376--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62a74065892e410008782cc2
😎 Deploy Preview https://deploy-preview-1376--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62a7406598073b00082d1b65

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62a74065892e410008782cbd
😎 Deploy Preview https://deploy-preview-1376--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for next-i18next-demo canceled.

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62a7406508aaba0008600c26

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62a74065949f7300092233af
😎 Deploy Preview https://deploy-preview-1376--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for next-plugin-edge-middleware canceled.

Name Link
🔨 Latest commit 38ca9bf
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62a74065eda9c10007063f81

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for next-plugin-canary failed.

Name Link
🔨 Latest commit b08522d
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62a34e193d7c8e0009ce8079

@cypress
Copy link

cypress bot commented Jun 9, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit ea03140 ℹ️
Started Jun 13, 2022 1:54 PM
Ended Jun 13, 2022 1:55 PM
Duration 01:14 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 9, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit ea03140 ℹ️
Started Jun 13, 2022 1:52 PM
Ended Jun 13, 2022 1:54 PM
Duration 01:12 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 9, 2022



Test summary

21 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit ea03140 ℹ️
Started Jun 13, 2022 1:52 PM
Ended Jun 13, 2022 1:54 PM
Duration 01:36 💡
OS Linux Ubuntu - 20.04
Browser Chrome 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid! 🎉

@sarahetter sarahetter merged commit 3674b1c into main Jun 13, 2022
@sarahetter sarahetter deleted the codeowners branch June 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants