Skip to content

chore: add example of cookies api to middleware demo #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2022
Merged

chore: add example of cookies api to middleware demo #1350

merged 2 commits into from
May 13, 2022

Conversation

sarahetter
Copy link

Summary

Adds a small example of the cookies API to the middleware demo.

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Screen Shot 2022-05-13 at 9 38 11 AM

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@sarahetter sarahetter requested a review from a team May 13, 2022 13:40
@sarahetter sarahetter self-assigned this May 13, 2022
@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/627e5fd41932550008f52ee7
😎 Deploy Preview https://deploy-preview-1350--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/627e5fd4b8710600097bca8e
😎 Deploy Preview https://deploy-preview-1350--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/627e5fd4f1665b0009eb1720
😎 Deploy Preview https://deploy-preview-1350--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/627e5fd434012c00084e611f
😎 Deploy Preview https://deploy-preview-1350--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label May 13, 2022
@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/627e5fd485e7980008e6b106
😎 Deploy Preview https://deploy-preview-1350--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/627e5fd4a5c7450008787aea
😎 Deploy Preview https://deploy-preview-1350--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/627e5fd4a13c610008e0819d

@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for next-i18next-demo canceled.

Name Link
🔨 Latest commit ac51622
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/627e5fd4b8710600097bca93

@cypress
Copy link

cypress bot commented May 13, 2022


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 286ed05 ℹ️
Started May 13, 2022 1:43 PM
Ended May 13, 2022 1:45 PM
Duration 01:18 💡
OS Linux Ubuntu - 20.04
Browser Chrome 101

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 13, 2022


Test summary

22 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 286ed05 ℹ️
Started May 13, 2022 1:43 PM
Ended May 13, 2022 1:45 PM
Duration 01:23 💡
OS Linux Ubuntu - 20.04
Browser Chrome 101

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 13, 2022


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 286ed05 ℹ️
Started May 13, 2022 1:44 PM
Ended May 13, 2022 1:45 PM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 101

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

ascorbic
ascorbic approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sarahetter sarahetter merged commit 52ae761 into main May 13, 2022
@sarahetter sarahetter deleted the cookies-api branch May 13, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

@sarahetter sarahetter

Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahetter @ascorbic