Skip to content

fix: specify version of next-auth #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

ericapisani
Copy link

@ericapisani ericapisani commented Apr 26, 2022

Summary

In the demo site for next-auth, the next-auth dependency was listed as 'latest'. When using the 'latest' tag, v3 of next-auth was being installed rather than v4.

This was causing build errors because the type definitions used in the example project aren't introduced until v4.

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

polar-bear-cub-6

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

When using the 'latest' tag, v3 of next-auth was being installed.

However, the type definitions used in the example project aren't introduced until v4.

Pinning to v4 in order to ensure expected behaviour
@ericapisani ericapisani added the type: chore work needed to keep the product and development running smoothly label Apr 26, 2022
@ericapisani ericapisani requested a review from a team April 26, 2022 15:51
@ericapisani ericapisani self-assigned this Apr 26, 2022
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62681517e1fc6e0008a0db64
😎 Deploy Preview https://deploy-preview-1328--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for netlify-plugin-nextjs-demo canceled.

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62681517d9a58d0008767ff8

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 26, 2022
@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6268151799bdec0009ea24eb
😎 Deploy Preview https://deploy-preview-1328--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6268151726a98200081a3550
😎 Deploy Preview https://deploy-preview-1328--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/626815176a130d0008c17f66
😎 Deploy Preview https://deploy-preview-1328--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for next-plugin-edge-middleware canceled.

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/626815171fdd2c000940c207

@netlify
Copy link

netlify bot commented Apr 26, 2022

Deploy Preview for next-plugin-rsc-demo canceled.

Name Link
🔨 Latest commit 6622b49
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62681517f501d10008aaaf03

@cypress
Copy link

cypress bot commented Apr 26, 2022



Test summary

2 20 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Failed
Commit 0a020f9 ℹ️
Started Apr 26, 2022 3:54 PM
Ended Apr 26, 2022 3:55 PM
Duration 01:38 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

i18n.spec.ts Failed
1 Localization > should use sub routing to determine current locale
2 Localization > should use the NEXT_LOCALE cookie to determine the default locale
3 Localization > should use the NEXT_LOCALE cookie over Accept-Language header to determine the default locale
rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
2 Rewrites and Redirects > redirects: redirects /redirectme to /
default.spec.ts Failed
1 Default site > loads home page
2 Default site > sets NODE_ENV
preview.spec.ts Failed
1 Preview Mode > enters and exits preview mode
trailing-slash.spec.ts Failed
1 Trailing slash enabled > should put a trailing slash when there is none, i.e. points /old to /old/
custom-errors.spec.ts Failed
1 Custom error pages > should show custom 404 page on /404
This comment includes only the first 10 test failures. See all 20 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 26, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 0a020f9 ℹ️
Started Apr 26, 2022 3:55 PM
Ended Apr 26, 2022 3:56 PM
Duration 01:13 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cypress
Copy link

cypress bot commented Apr 26, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 0a020f9 ℹ️
Started Apr 26, 2022 3:55 PM
Ended Apr 26, 2022 3:56 PM
Duration 01:08 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kodiakhq kodiakhq bot merged commit f2bfffc into main Apr 26, 2022
@kodiakhq kodiakhq bot deleted the ep/specify-next-auth-version branch April 26, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants