refactor: move into npm workspace

.github/workflows/release-please.yml

@@ -16,25 +16,27 @@ jobs:
         id: release
         with:
           token: ${{ steps.get-token.outputs.token }}
-          release-type: node
-          package-name: '@netlify/plugin-nextjs'
+          command: manifest
       - uses: actions/checkout@v2
-        if: ${{ steps.release.outputs.release_created }}
+        if: ${{ steps.release.outputs.releases_created }}
       - uses: actions/setup-node@v2
         with:
           node-version: '*'
           cache: 'npm'
           check-latest: true
           registry-url: 'https://registry.npmjs.org'
-        if: ${{ steps.release.outputs.release_created }}
+        if: ${{ steps.release.outputs.releases_created }}
       - name: Install dependencies
         run: npm ci
-        if: ${{ steps.release.outputs.release_created }}
+        working-directory: plugin
+        if: ${{ steps.release.outputs.releases_created }}
       - run: npm publish
-        if: ${{ steps.release.outputs.release_created }}
+        working-directory: plugin
+        if: ${{ steps.release.outputs.releases_created }}
         env:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
       - uses: netlify/submit-build-plugin-action@v1
-        if: ${{ steps.release.outputs.release_created }}
+        if: ${{ steps.release.outputs.releases_created }}
         with:
           github-token: ${{ steps.get-token.outputs.token }}
+          package-json-dir: plugin

.github/workflows/test.yml

@@ -25,13 +25,20 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Installing with latest Node.js
         uses: actions/setup-node@v2
+        if: "${{ matrix.node-version != '*' }}"
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: '*'
           check-latest: true
       - name: NPM Install
         run: npm ci
+      - name: Switching to Node.js ${{ matrix.node-version }} to run tests
+        uses: actions/setup-node@v2
+        if: "${{ matrix.node-version != '*' }}"
+        with:
+          node-version: ${{ matrix.node-version }}
+          check-latest: true
       - name: Linting
         run: npm run format:ci
         if: "${{ matrix.node-version == '*' }}"
@@ -55,14 +62,21 @@ jobs:
     if: github.ref_name == 'main'
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Installing with latest Node.js
         uses: actions/setup-node@v2
+        if: "${{ matrix.node-version != '*' }}"
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: '*'
           check-latest: true
       - name: NPM Install
         run: npm ci
       - name: Install Next.js Canary
         run: npm install -D next@canary --legacy-peer-deps
+      - name: Switching to Node.js ${{ matrix.node-version }} to run tests
+        uses: actions/setup-node@v2
+        if: "${{ matrix.node-version != '*' }}"
+        with:
+          node-version: ${{ matrix.node-version }}
+          check-latest: true
       - name: Run tests against next@canary
         run: npm test

.nvmrc

@@ -0,0 +1 @@
+17.9.0

.prettierignore

@@ -3,6 +3,8 @@ logs
 *.log
 npm-debug.log*
 
+package.json
+
 # Dependency directories
 node_modules
 

.release-please-manifest.json

@@ -0,0 +1,3 @@
+{
+  "plugin": "4.3.2"
+}

demos/base-path/netlify.toml

@@ -12,10 +12,9 @@ CYPRESS_CACHE_FOLDER = "../node_modules/.CypressBinary"
 framework = "#static"
 
 [[plugins]]
-package = "./local-plugin"
+package = "../plugin-wrapper/"
 
 [[plugins]]
 package = "@netlify/plugin-local-install-core"
-
 # [[context.deploy-preview.plugins]]
-# package = "netlify-plugin-cypress"
+# package = "netlify-plugin-cypress"

demos/base-path/package.json

@@ -0,0 +1,22 @@
+{
+  "name": "base-path-demo",
+  "version": "1.0.0",
+  "description": "",
+  "devDependencies": {
+    "@netlify/plugin-nextjs": "*"
+  },
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/netlify/netlify-plugin-nextjs.git"
+  },
+  "author": "",
+  "private": true,
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/netlify/netlify-plugin-nextjs/issues"
+  },
+  "homepage": "https://github.com/netlify/netlify-plugin-nextjs#readme"
+}

demos/default/netlify.toml

@@ -1,20 +1,22 @@
 [build]
 command = "next build"
 publish = ".next"
-ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ../../"
+ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../plugin"
 
 [build.environment]
 # cache Cypress binary in local "node_modules" folder
 # so Netlify caches it
 CYPRESS_CACHE_FOLDER = "../node_modules/.CypressBinary"
 # set TERM variable for terminal output
 TERM = "xterm"
+NODE_VERSION = "17"
 
 [dev]
 framework = "#static"
 
 [[plugins]]
-package = "./local-plugin"
+package = "../plugin-wrapper/"
 
+# This is a fake plugin, that makes it run npm install
 [[plugins]]
-package = "@netlify/plugin-local-install-core"
+package = "@netlify/plugin-local-install-core"

demos/default/package.json

@@ -0,0 +1,26 @@
+{
+  "name": "default-demo",
+  "version": "1.0.0",
+  "private": true,
+  "description": "",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/netlify/netlify-plugin-nextjs.git"
+  },
+  "author": "",
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/netlify/netlify-plugin-nextjs/issues"
+  },
+  "homepage": "https://github.com/netlify/netlify-plugin-nextjs#readme",
+  "dependencies": {
+    "@reach/dialog": "^0.16.2",
+    "@reach/visually-hidden": "^0.16.0"
+  },
+  "devDependencies": {
+    "@netlify/plugin-nextjs": "*"
+  }
+}

demos/default/pages/env.tsx

@@ -1,19 +1,39 @@
+import { useEffect, useState } from 'react'
+
 /**
  * https://nextjs.org/docs/basic-features/environment-variables
  */
 function EnvTest() {
+  const [showEnv, setShowEnv] = useState(false)
+  useEffect(() => setShowEnv(true), [])
   return (
     <div>
       <h1>Environment Variables</h1>
       <a href="https://nextjs.org/docs/basic-features/environment-variables">Read Docs</a>
-      <p>By default environment variables are only available in the Node.js environment, meaning they won&apos;t be exposed to the browser.</p>
       <p>
-        <code>NEXT_PUBLIC_</code> environment variables are available in the browser, and can be used to configure the application.
+        By default environment variables are only available in the Node.js environment, meaning they won&apos;t be
+        exposed to the browser.
+      </p>
+      <p>
+        <code>NEXT_PUBLIC_</code> environment variables are available in the browser, and can be used to configure the
+        application.
       </p>
-      <p>✅ Public Environment token found: <code>{process.env.NEXT_PUBLIC_GREETINGS || 'NOT FOUND (something went wrong)'}</code></p>
-      <p>❌ Private Environment token should not be found:   <code>{process.env.TEST_ENV_VAR || 'Everything worked'}</code></p>
+      {showEnv ? (
+        <>
+          <p>
+            ✅ Public Environment token found:{' '}
+            <code>{process.env.NEXT_PUBLIC_GREETINGS || 'NOT FOUND (something went wrong)'}</code>
+          </p>
+          <p>
+            ❌ Private Environment token should not be found:{' '}
+            <code>{process.env.TEST_ENV_VAR || 'Everything worked'}</code>
+          </p>
+        </>
+      ) : (
+        'We only want to test client-side env vars'
+      )}
     </div>
   )
 }
 
-export default EnvTest
+export default EnvTest

demos/default/tsconfig.json

@@ -1,23 +1,17 @@
 {
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "target": "es5",
     "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
+      "es2019",
+      "dom"
     ],
-    "allowJs": true,
-    "skipLibCheck": true,
     "strict": false,
-    "forceConsistentCasingInFileNames": true,
     "noEmit": true,
-    "esModuleInterop": true,
-    "module": "esnext",
+    "incremental": true,
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "isolatedModules": true,
-    "jsx": "preserve",
-    "incremental": true
+    "jsx": "preserve"
   },
   "include": [
     "next-env.d.ts",
@@ -27,4 +21,4 @@
   "exclude": [
     "node_modules"
   ]
-}
+}

demos/next-export/netlify.toml

@@ -5,12 +5,13 @@ ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ../../"
 
 [build.environment]
 NETLIFY_NEXT_PLUGIN_SKIP = "true"
+NODE_VERSION = "17"
 
 [dev]
 framework = "#static"
 
 [[plugins]]
-package = "./local-plugin"
+package = "../plugin-wrapper/"
 
 [[plugins]]
 package = "@netlify/plugin-local-install-core"

demos/next-export/package.json

@@ -0,0 +1,22 @@
+{
+  "name": "next-export-demo",
+  "version": "1.0.0",
+  "description": "",
+  "devDependencies": {
+    "@netlify/plugin-nextjs": "*"
+  },
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/netlify/netlify-plugin-nextjs.git"
+  },
+  "author": "",
+  "private": true,
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/netlify/netlify-plugin-nextjs/issues"
+  },
+  "homepage": "https://github.com/netlify/netlify-plugin-nextjs#readme"
+}

demos/nx-next-monorepo-demo/local-plugin/index.js

@@ -1 +1 @@
-module.exports = require('../../../lib')
+module.exports = require('../../../plugin/lib')

demos/plugin-wrapper/index.js

@@ -0,0 +1,2 @@
+// eslint-disable-next-line node/no-unpublished-require
+module.exports = require('../../plugin/lib')

demos/plugin-wrapper/manifest.yml

@@ -0,0 +1 @@
+name: 'plugin-wrapper'

demos/plugin-wrapper/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "local-plugin",
+  "version": "1.0.0",
+  "main": "index.js",
+  "author": "",
+  "license": "MIT",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "devDependencies": {
+    "@netlify/plugin-nextjs": "*",
+    "husky": "^7.0.4",
+    "npm-run-all": "^4.1.5"
+  }
+}

demos/static-root/netlify.toml

@@ -7,15 +7,13 @@ ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ../../"
 # cache Cypress binary in local "node_modules" folder
 # so Netlify caches it
 CYPRESS_CACHE_FOLDER = "../node_modules/.CypressBinary"
+NODE_VERSION = "17"
 
 [dev]
 framework = "#static"
 
 [[plugins]]
-package = "./local-plugin"
+package = "../plugin-wrapper/"
 
 [[plugins]]
 package = "@netlify/plugin-local-install-core"
-
-[[context.deploy-preview.plugins]]
-package = "netlify-plugin-cypress"