Skip to content

chore: update the path for the import of type ImageConfigComplete #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 4, 2022

Conversation

ericapisani
Copy link

Summary

Updates the import path of a Typescript type.

Test plan

  1. Running npm run build now completes successfully. Previously this would fail.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Related pull request in NextJS that made the change: vercel/next.js#34677

cute_panda


🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ericapisani ericapisani added the type: chore work needed to keep the product and development running smoothly label Mar 31, 2022
@ericapisani ericapisani requested a review from a team March 31, 2022 19:26
@ericapisani ericapisani self-assigned this Mar 31, 2022
@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 3fca9a7
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/624b0e4e5e041600082e7679
😎 Deploy Preview https://deploy-preview-1289--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 3fca9a7
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/624b0e4e9cecf600083b5532
😎 Deploy Preview https://deploy-preview-1289--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 3fca9a7
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/624b0e4e50cdaf0008a88971
😎 Deploy Preview https://deploy-preview-1289--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 3fca9a7
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/624b0e4e2e56bc000811a41d
😎 Deploy Preview https://deploy-preview-1289--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic
Copy link
Contributor

ascorbic commented Apr 1, 2022

Aaah, they've released the new version. To get everythign to build, we need to update the Next versions used in the demo sites.

Regenerate package-lock.json file
@cypress
Copy link

cypress bot commented Apr 1, 2022



Test summary

22 0 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 527dbb5 ℹ️
Started Apr 4, 2022 3:30 PM
Ended Apr 4, 2022 3:32 PM
Duration 01:28 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 1, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 527dbb5 ℹ️
Started Apr 4, 2022 3:30 PM
Ended Apr 4, 2022 3:31 PM
Duration 01:11 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 1, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 527dbb5 ℹ️
Started Apr 4, 2022 3:30 PM
Ended Apr 4, 2022 3:32 PM
Duration 01:21 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ericapisani ericapisani marked this pull request as ready for review April 1, 2022 18:26
@ascorbic
Copy link
Contributor

ascorbic commented Apr 4, 2022

Nice one! Just needs the package lock conflicts resolving and we can get it in

@kodiakhq kodiakhq bot merged commit 830b9aa into main Apr 4, 2022
@kodiakhq kodiakhq bot deleted the ep-update-type-import branch April 4, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants