Skip to content

chore: Add details to cypress and remove extra matrix #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2022
Merged

chore: Add details to cypress and remove extra matrix #1263

merged 4 commits into from
Mar 15, 2022

Conversation

tiffafoo
Copy link

@tiffafoo tiffafoo commented Mar 14, 2022 •
edited
Loading

Summary

Update machines according to Cypress dashboard guidelines. Also adds group naming for better understanding of test runs

CleanShot 2022-03-14 at 17 07 49@2x

Test plan

See that tests in actions run as expected

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

https://docs.cypress.io/guides/continuous-integration/github-actions#Cypress-GitHub-Action

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

🌠 Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 6e66bd1
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6230757ce840c80008d07e77
😎 Deploy Preview https://deploy-preview-1263--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

😁 Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 6e66bd1
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6230757c793516000918b60e
😎 Deploy Preview https://deploy-preview-1263--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

⚡️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 6e66bd1
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6230757cd9fc6b000992c164
😎 Deploy Preview https://deploy-preview-1263--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

💛 Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 6e66bd1
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6230757ce840c80008d07e7c
😎 Deploy Preview https://deploy-preview-1263--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code... QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Mar 14, 2022 •
edited
Loading


Test summary

22 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 5281906 ℹ️
Started Mar 15, 2022 11:20 AM
Ended Mar 15, 2022 11:21 AM
Duration 01:26 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 14, 2022 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 5281906 ℹ️
Started Mar 15, 2022 11:20 AM
Ended Mar 15, 2022 11:21 AM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 14, 2022 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 5281906 ℹ️
Started Mar 15, 2022 11:20 AM
Ended Mar 15, 2022 11:21 AM
Duration 01:14 💡
OS Linux Ubuntu - 20.04
Browser Chrome 98

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tiffafoo tiffafoo changed the title chore: 6 -> 4 matrix chore: Add details to cypress and remove extra matrix Mar 14, 2022
@tiffafoo tiffafoo marked this pull request as ready for review March 14, 2022 22:09
@tiffafoo tiffafoo requested a review from a team March 14, 2022 22:09
@tiffafoo
Copy link
Author

This also attempts to reproduce a cypress error that matt is seeing, but unsuccessfully

ascorbic
ascorbic approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ascorbic
Copy link
Contributor

ascorbic commented Mar 15, 2022 •
edited
Loading

The unit tests are failing because #1260 needs merging first

@kodiakhq kodiakhq bot merged commit 3675e35 into main Mar 15, 2022
@kodiakhq kodiakhq bot deleted the tln/cypress-less-matrix branch March 15, 2022 11:30
@ascorbic ascorbic restored the tln/cypress-less-matrix branch March 15, 2022 11:30
@sarahetter sarahetter mentioned this pull request Jun 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiffafoo @ascorbic