-
Notifications
You must be signed in to change notification settings - Fork 89
chore: add more docs #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more docs #1130
Conversation
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 6c5416b 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61e93b3540c17e0008d3e812 😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 6c5416b 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61e93b356a2c680007964277 😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: 6c5416b 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61e93b35cdfbdd00079094f6 😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-export-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 6c5416b 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61e93b354ca0610007d35334 😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-static-root-demo.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on the docs review. I put @KyleBlankRollins on there and removed myself as a reviewer, as he'll be the pillar docs lead moving forward. |
I'll review this today! Planning to get to it sooner rather than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @ascorbic! I have a few minor, non-blocking suggestions.
Co-authored-by: Kyle Rollins <[email protected]>
90b50dc
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes, Matt! Looks great!
Summary
Adds notes and documentation updates, as requested in various issues.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes #871. Closes #1008. Closes #953.

Closes #994 (using doc rather than logging, as the correct info is not available at build time)
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.