Skip to content

chore: add more docs #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2022
Merged

chore: add more docs #1130

merged 4 commits into from
Jan 20, 2022

Conversation

ascorbic
Copy link
Contributor

Summary

Adds notes and documentation updates, as requested in various issues.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Closes #871. Closes #1008. Closes #953.
Closes #994 (using doc rather than logging, as the correct info is not available at build time)
capybaras

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@ascorbic ascorbic self-assigned this Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 6c5416b

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61e93b3540c17e0008d3e812

😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 6c5416b

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61e93b356a2c680007964277

😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-demo.netlify.app

@ascorbic ascorbic requested a review from tiffafoo January 17, 2022 10:33
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

🔨 Explore the source changes: 6c5416b

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61e93b35cdfbdd00079094f6

😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-export-demo.netlify.app

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 6c5416b

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61e93b354ca0610007d35334

😎 Browse the preview: https://deploy-preview-1130--netlify-plugin-nextjs-static-root-demo.netlify.app

tiffafoo
tiffafoo previously approved these changes Jan 17, 2022
Copy link

@tiffafoo tiffafoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascorbic ascorbic requested a review from rstavchansky January 17, 2022 10:50
@rstavchansky rstavchansky requested review from KyleBlankRollins and removed request for rstavchansky January 19, 2022 15:15
@rstavchansky
Copy link

Thanks for your patience on the docs review. I put @KyleBlankRollins on there and removed myself as a reviewer, as he'll be the pillar docs lead moving forward.

@KyleBlankRollins
Copy link

I'll review this today! Planning to get to it sooner rather than later.

Copy link

@KyleBlankRollins KyleBlankRollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ascorbic! I have a few minor, non-blocking suggestions.

@cypress
Copy link

cypress bot commented Jan 19, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 1f689b2
Started Jan 19, 2022 4:55 PM
Ended Jan 19, 2022 4:56 PM
Duration 01:11 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jan 19, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 1f689b2
Started Jan 19, 2022 4:55 PM
Ended Jan 19, 2022 4:56 PM
Duration 01:19 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jan 19, 2022



Test summary

15 2 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Failed
Commit 1f689b2
Started Jan 19, 2022 4:56 PM
Ended Jan 19, 2022 4:58 PM
Duration 02:21 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️


Failures

rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
test.spec.ts Failed
1 TypeScript spec > loads home page

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@KyleBlankRollins KyleBlankRollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, Matt! Looks great!

@kodiakhq kodiakhq bot merged commit 968c1bc into main Jan 20, 2022
@kodiakhq kodiakhq bot deleted the mk/misc-docs branch January 20, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
4 participants