fix: handle routes-manifests without staticRoutes defined
#1120
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: abf69e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61e00849d777680007c333c6 😎 Browse the preview: https://deploy-preview-1120--netlify-plugin-nextjs-export-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: abf69e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61e0084957bc7100070013d0 😎 Browse the preview: https://deploy-preview-1120--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: abf69e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61e0084967ae2f00081d8e73 😎 Browse the preview: https://deploy-preview-1120--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: abf69e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61e008495a996d0007503e88 😎 Browse the preview: https://deploy-preview-1120--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
ascorbic
changed the title
routes-manifests without staticRoutes defined
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -46,7 +46,7 @@ export interface RoutesManifest { | |||
| redirects: Redirect[] | |||
| headers: Header[] | |||
| dynamicRoutes: DynamicRoute[] | |||
| staticRoutes: StaticRoute[] | |||
| staticRoutes?: StaticRoute[] | |||
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures are unavailable for this run. For more information, see the Cypress Dashboard This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Summary
Pre-Next 12, static routes weren't included in the routes manifest. We deal with that here with an optional chain.
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.