-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add support for use with next export
#1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: c71c52c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61bb4cca3073c100072447e6 😎 Browse the preview: https://deploy-preview-1012--netlify-plugin-nextjs-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: c71c52c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61bb4ccaa6b0bc0008863691 😎 Browse the preview: https://deploy-preview-1012--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: c71c52c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61bb4ccacc62f80008e9b3ea 😎 Browse the preview: https://deploy-preview-1012--netlify-plugin-nextjs-static-root-demo.netlify.app |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: c71c52c 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61bb4cca43740b0007015ca4 😎 Browse the preview: https://deploy-preview-1012--netlify-plugin-nextjs-export-demo.netlify.app |
@tiffanosaurus Is there a way we can disable cypress in the "netlify-plugin-nextjs-skip-demo" site? |
...I've done it by creating a new demo |
next export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆 Running ntl build with the env var set on the next-export demo shows the warning
Summary
Currently the plugin fails the build if
next export
is used, which can be annoying for sites that have it auto-installed. This PR adds support for an env varNETLIFY_NEXT_PLUGIN_SKIP
to disable everything except caching in the plugin. This can be set in a template or via the deploy button. It also supports settingNEXT_PLUGIN_FORCE_RUN
to"false"
for backward-compatibility with the old plugin.This PR also adds a
next export
demo that uses this env varTest plan
NETLIFY_NEXT_PLUGIN_SKIP=1 ntl build
The
netlify-plugin-nextjs-export-demo
site has this set, so you can see the build status reportedRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
#503
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.