Skip to content

Do not require react nor react-dom #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ehmicky opened this issue Nov 19, 2020 · 1 comment · Fixed by #60
Closed

Do not require react nor react-dom #59

ehmicky opened this issue Nov 19, 2020 · 1 comment · Fixed by #60
Assignees
@ehmicky
Labels
proj/non/next-on-netlify-enterprise type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link

ehmicky commented Nov 19, 2020

We currently use require('next') to check whether the website is using Next.js.
However, this requires react and react-dom to also be available.
Doing require('next/package.json') instead should solve this. It's also faster.
@ehmicky ehmicky added type: bug code to address defects in shipped code proj/non/next-on-netlify-enterprise labels Nov 19, 2020
@ehmicky ehmicky mentioned this issue Nov 19, 2020
Merged
@ehmicky ehmicky self-assigned this Nov 19, 2020
@ehmicky
Copy link
Author

ehmicky commented Nov 19, 2020

Done in #60

serhalp pushed a commit that referenced this issue Apr 5, 2024
@token-generator-app
chore(main): release 5.0.0-alpha.0 (#59)
fd3a938 
Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehmicky ehmicky

Labels
proj/non/next-on-netlify-enterprise type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix react peer dependency opennextjs/opennextjs-netlify
1 participant
@ehmicky