failBuild needs to be passed to getNextConfig
#567
Labels
wontfix
This will not be worked on
Comments
serhalp
added a commit
that referenced
this issue
Jun 13, 2024
* chore(e2e): fix parsing of JUnit XML file numbers These are all returned as strings, so it's easy to introduce bugs downstream if we don't immediately convert them explicitly to numbers. This fixes some cases where we render `NaN` on the report page. * chore(e2e): fix rendering of skipped tests in main section If all the tests in a suite were individually skipped, we ended up with an empty section and a `Nan%`. * ci(e2e): fix default for workflow_dispatch versions input * chore(e2e): handle retries in next.js e2e results Remove all suites known to be fully passing from the `e2e-skip-retry.json`, add logic to handle retries in the test results, thread this through to the final results, and show retry info on the report page. Every suite was added to this list in order to tame the test run time, but now that we're around a 98% pass rate, the impact of enabling retries should be minimal. * refactor(e2e): simplify and clarify junit2json skip handling * chore(e2e): don't duplicate tests skipped via config These were ending up inserted because they're skipped and inserted a second time if they also ran and failed. The same could technically happen if it passed and was skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In several places we are calling
getNextConfigwithout passing itutils.failBuild. This means that any error uses the default handler, which throws an error and is reported as a plugin error. We should pass the util into the NoN runner and pass it through to all of ther functions that need it. Alternatively we should just pass the config through isntead.The text was updated successfully, but these errors were encountered: