Skip to content

Properly test nextOnNetlify functionality in onBuild part of plugin #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lindsaylevine opened this issue Nov 18, 2020 · 1 comment · Fixed by #65
Closed

Properly test nextOnNetlify functionality in onBuild part of plugin #53

lindsaylevine opened this issue Nov 18, 2020 · 1 comment · Fixed by #65
Assignees
@lindsaylevine
Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@lindsaylevine
Copy link

cc: @ehmicky
@lindsaylevine lindsaylevine added type: feature code contributing to the implementation of a feature and/or user facing functionality proj/non/next-on-netlify-enterprise labels Nov 18, 2020
@lindsaylevine lindsaylevine mentioned this issue Nov 18, 2020
Merged
@lindsaylevine lindsaylevine self-assigned this Nov 20, 2020
@ehmicky
Copy link

ehmicky commented Nov 24, 2020

To be explicit, this is about stopping to mock next-on-netlify, i.e. testing if it integrates properly with this plugin.

lindsaylevine added a commit that referenced this issue Nov 25, 2020
@lindsaylevine
#53 properly test next-on-netlify in onBuild
7252626
@lindsaylevine lindsaylevine mentioned this issue Nov 25, 2020
Merged
lindsaylevine added a commit that referenced this issue Dec 2, 2020
@lindsaylevine @ehmicky
#53 properly test next-on-netlify in onBuild (#65)
9da8be5 
* use .next dist to properly test next-on-netlify

* update next-on-netlify testing to use sample/.next dist

* move /test/fixtures/sample to /test/sample

* Fix files copy

* Fix sample directory and delete files

* remove unnecessary items

* remove plugins dir in test/sample

Co-authored-by: ehmicky <[email protected]>
serhalp pushed a commit that referenced this issue Apr 5, 2024
@lukasholzer
feat: add on demand revalidation by tags and path (#53)
85aac60 
* feat: add on demand revalidation by tags and path

* chore: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindsaylevine lindsaylevine

Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#53 properly test next-on-netlify in onBuild opennextjs/opennextjs-netlify
2 participants
@ehmicky @lindsaylevine