Updated openssl and ffmpeg in a dockerfile, turned on building libpng #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dockerfile, turned on building libpng
asenyaev
force-pushed
the
asen/update_dockerfile
branch
from
8edc83f to
0a17e6c
Compare
|
Addresses #614. |
asmorkalov
reviewed
Jan 25, 2022
docker/manylinux2014/Dockerfile_i686
Outdated
| cd openssl-OpenSSL_1_1_1g && \ | ||
| curl -O -L https://github.com/openssl/openssl/archive/OpenSSL_1_1_1m.tar.gz && \ | ||
| tar -xf OpenSSL_1_1_1m.tar.gz && \ | ||
| cd openssl-OpenSSL_1_1_1m && \ |
There was a problem hiding this comment.
I propose to use Docker ARG to define version of software everywhere like:
ARG SSL_VERSION=1_1_1g
RUN ... curl -O -L https://github.com/openssl/openssl/archive/OpenSSL_${SSL_VERSION}.tar.gz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.