Skip to content

Build on Travis CI using manylinux #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2016
Merged

Conversation

c-martinez
Copy link
Contributor

This PR should address previous suggestion #1. Builds on Travis seem fine (except for 2.6).

Couple of issues

  • Currently not building for 2.6, because it complains gives ImportError: cannot import name SkipTest
  • build-wheels.sh will need to be changed in the future:
    • It force-updates auditwheel (until the docker image updates auditwheel)
    • It clones OpenCV from my own fork -- if this is the way forward to build OpenCV wheels, I'll send a PR upstream to incorporate the few changes required.

Is this useful?

@skvark
Copy link
Member

skvark commented Jul 2, 2016

Appveyor build file needs minor fix, but otherwise LGTM.

I don't really know the answer to the question if this is the way forward to build OpenCV wheels. If you have a better idea, please share. As the OpenCV maintainers are a bit reluctant to include Python packaging support directly to the main repo (opencv/opencv#6516), I think this separate repository + cloning OpenCV is pretty much the only option there is.

@c-martinez
Copy link
Contributor Author

Changed the Appveyor build (hopefully it works correctly).

I think you are right and cloning OpenCV to build the wheels might be the only option. I guess what we are missing now is registering the wheels in PyPI. Do you have any experience with it? Otherwise I guess I can figure it out.

@skvark
Copy link
Member

skvark commented Jul 4, 2016

I have experience running a local PyPI and I can do the uploading. However, there are still a few things to do:

  • the builds (cloning) have to be done from the main OpenCV repository
  • versioning:
    • do we pull only the latest tag and make builds for it or do we also offer dev builds which are essentially built always when there's a commit in the OpenCV main development branch
  • OS X wheels
  • Are the Linux wheels allowed in PyPI (at some point they weren't)

I will create separate issues for these.

@skvark skvark closed this Jul 4, 2016
@skvark skvark reopened this Jul 4, 2016
@skvark skvark merged commit 40d36e4 into opencv:master Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants