Skip to content

generate: add --linux-device-cgroup-add and --linux-device-cgroup-remove #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Aug 21, 2017

These options allow user to configures the device whitelist.

Usage:

oci-runtime-tool generate \
--linux-device-cgroup-remove=deny,access=rwm \
--linux-device-cgroup-add=allow,type=c,major=10,minor=229,access=rw \
-linux-device-cgroup-add=allow,type=b,major=8,minor=0,access=r

Closes #314

This is a rebase of #314

Signed-off-by: Zhai Zhaoxuan [email protected]
Signed-off-by: zhouhao [email protected]

@zhouhao3 zhouhao3 force-pushed the add-linux-resources-device branch 2 times, most recently from e6bee7d to 9bf0e4b Compare August 21, 2017 09:21
These options allow user to configures the device whitelist.

Signed-off-by: Zhai Zhaoxuan <[email protected]>
@zhouhao3 zhouhao3 force-pushed the add-linux-resources-device branch 2 times, most recently from 2d28c9b to 158fd56 Compare August 21, 2017 09:37
…-access-remove

Signed-off-by: Zhai Zhaoxuan <[email protected]>
Signed-off-by: zhouhao <[email protected]>
@zhouhao3 zhouhao3 force-pushed the add-linux-resources-device branch from 158fd56 to fa9842c Compare August 30, 2017 02:28
@zhouhao3 zhouhao3 changed the title generate: add --linux-resources-device-add and --linux-resources-devi… generate: add --linux-device-cgroup-add and --linux-device-cgroup-remove Aug 30, 2017
@zhouhao3
Copy link
Author

@opencontainers/runtime-tools-maintainers PTAL

@Mashimiao Mashimiao added this to the v0.6.0 milestone Sep 26, 2017
@Mashimiao
Copy link

Mashimiao commented Oct 18, 2017

LGTM

Approved with PullApprove

@zhouhao3
Copy link
Author

ping @liangchenye

@liangchenye
Copy link
Member

liangchenye commented Oct 18, 2017

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit e7dd7e5 into opencontainers:master Oct 18, 2017
@zhouhao3 zhouhao3 deleted the add-linux-resources-device branch October 18, 2017 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants