Add type helpers only when used #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
reviewed
Nov 16, 2022
| }); | ||
| }); | ||
|
|
||
| describe("OneOf type helpers", () => { |
drwpow
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
LGTM! Yeah in general I’d like to avoid scanning text if possible, but profiling this it seems to be fast enough to not have any real performance impacts even on big schemas, so this works for me!
But if more things were added to text scanning we might want to move a boolean flag into global context or something; this is fine but some other text scanning methods may have serious performance concerns.
|
@all-contributors please add @imagoiq for code, test, bug |
|
I've put up a pull request to add @imagoiq! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #976 by checking if
OneOftype is added to the schema. The fix uses the easiest path, but perhaps not the best for long term (if there are other type helpers added especially). Perhaps, the context should be aware if type helpers are required? (if it's not already the case and that I miss something).