New --alphabetize switch: Sorts output file consistently
#942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrLeebo
commented
Sep 23, 2022
MrLeebo
changed the title
--alphabetize switch: Sorts output file consistently
drwpow
reviewed
Oct 3, 2022
drwpow
reviewed
Oct 3, 2022
drwpow
reviewed
Oct 3, 2022
drwpow
reviewed
Oct 3, 2022
drwpow
requested changes
Oct 3, 2022
|
@drwpow is there anything else I can do to help move this along? |
|
This looks great! Sorry for the delay; will merge this today. Just a heads up: this will be released in the |
drwpow
approved these changes
Oct 29, 2022
|
Merged exactly as-is in #966. Just fixed the test error & merge conflict but made no changes. |
|
@all-contributors please add @MrLeebo for code, test |
|
I've put up a pull request to add @MrLeebo! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--alphabetizeswitch that sorts the entries in the typescript output file alphabetically. This ensures the typescript file appears in a consistent sort order. Sometimes with dynamically generated docs, the order of the operations can change just depending on the timing of when each controller gets parsed. This can create trouble if you're checking your types into git. It can be difficult to review what changes were actually made when the only thing you can see in git diff is all of the operations being shuffled around.