Skip to content

fix(ISSUE-810): oneOf/allOf/anyOf fixing #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

sadfsdfdsa
Copy link
Contributor

Issue: #810

Type: FIX
Tests: 100%
Affects: oneOf/allOf/anyOf

Now doesn't crash while parse the empty oneOf/allOf/anyOf type, for dummy placeholder uses undefined for all empty xOf types:

image

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2021

⚠️ No Changeset found

Latest commit: ef103f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow
Copy link
Contributor

drwpow commented Dec 27, 2021

Same as the other PR—this will need to be rebased, but overall I’m in favor of it! I’d love to approve & merge once tests are passing.

@sadfsdfdsa sadfsdfdsa force-pushed the pr/810-issue-oneof-fix branch from 64e67cd to 888e8a5 Compare December 27, 2021 20:11
@sadfsdfdsa
Copy link
Contributor Author

@drwpow rdy to be merged

@deannashih
Copy link

deannashih commented Jan 4, 2022

@sadfsdfdsa Sorry, just saw your comments from #810. I think undefined is fine! Better than my having to manually remove the fields with the empty *Ofs altogether. Let me know when I can update my app to use these changes. Thanks a bunch!

edit: cc'ing @drwpow. thank you!!

@drwpow drwpow merged commit 1151a54 into openapi-ts:main Jan 11, 2022
@drwpow
Copy link
Contributor

drwpow commented Jan 11, 2022

@all-contributors please add @sadfsdfdsa for bug

@allcontributors
Copy link
Contributor

@drwpow

I've put up a pull request to add @sadfsdfdsa! 🎉

@drwpow
Copy link
Contributor

drwpow commented Jan 11, 2022

Released in 5.1.0! 🎉

@sadfsdfdsa
Copy link
Contributor Author

@deannashih released in 5.1.0

@sadfsdfdsa sadfsdfdsa deleted the pr/810-issue-oneof-fix branch January 11, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants