Feat: add support for "type": "file" in parameters #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
commented
Sep 30, 2021
| @@ -67,6 +77,11 @@ export function nodeType(obj: any): SchemaObjectType | undefined { | |||
| return "array"; | |||
| } | |||
|
|
|||
| // file | |||
| if (obj.type === "file") { | |||
| return "unknown"; | |||
There was a problem hiding this comment.
At least for now, we’ll return unknown for a file type. Because we’re not sure where this is running—server or browser—it would seem risky to simply assume a Buffer or string type for a file. Instead, we’ll rely on the implementer to specify how to deal with the file.
drwpow
force-pushed
the
feat-type-file
branch
from
c946fa0 to
b3095fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 96.34% 94.15% -2.19%
==========================================
Files 13 13
Lines 547 565 +18
Branches 194 197 +3
==========================================
+ Hits 527 532 +5
- Misses 19 32 +13
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #726. When
type: "file"is encountered in parameters, weird results occur.