Skip to content

Add docs for glob feature to README #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Add docs for glob feature to README #632

merged 3 commits into from
Jun 3, 2021

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jun 3, 2021

Adds glob docs to README, (#616), along with credit.

Also fixes an unreleased bug where specifying a glob pattern wouldn’t create the folder (it used the file behavior, where it would stop at the parent directory, as with single files, however with globs we need that last directory, too)

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #632 (7525141) into main (a36a728) will increase coverage by 1.48%.
The diff coverage is 87.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   88.53%   90.02%   +1.48%     
==========================================
  Files           9       10       +1     
  Lines         349      391      +42     
  Branches      123      142      +19     
==========================================
+ Hits          309      352      +43     
- Misses         37       39       +2     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
src/transform/headers.ts 23.07% <0.00%> (-4.20%) ⬇️
src/transform/index.ts 87.93% <78.78%> (+8.30%) ⬆️
src/transform/responses.ts 84.21% <81.81%> (-3.89%) ⬇️
src/transform/paths.ts 92.00% <87.50%> (ø)
src/transform/request.ts 95.00% <95.00%> (ø)
src/transform/schema.ts 97.59% <95.23%> (+0.53%) ⬆️
src/transform/parameters.ts 98.00% <96.42%> (+0.50%) ⬆️
src/index.ts 80.00% <100.00%> (+7.27%) ⬆️
src/transform/operation.ts 100.00% <100.00%> (+3.12%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba7056...7525141. Read the comment docs.

@drwpow drwpow force-pushed the glob-readme branch 3 times, most recently from 1e4e965 to d82ecda Compare June 3, 2021 04:15
@drwpow drwpow merged commit 56d4ddc into main Jun 3, 2021
@drwpow drwpow deleted the glob-readme branch June 3, 2021 04:23
@drwpow
Copy link
Contributor Author

drwpow commented Jun 3, 2021

cc @sharmarajdaksh please take a look at the README, and please submit a PR if you’d like to change anything 🙂

@sharmarajdaksh
Copy link
Contributor

Looks good, @drwpow, I don't really see anything that needs to be changed.
Cool work on parallelizing the spec generation for globs though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants