Fixed openapi 3 spec to default additionalProperties to true

[mehalter]

Resolves #583 . Let me know if this seems correct or if you have any comments/critiques!

Signed-off-by: Micah Halter [email protected]

[drwpow]

Reasoning makes sense! All on board for generating types that follow the spec. This looks great!

[drwpow]

Came here to check if you had an additionalProperties: false test, and you did! Great work 🙂

[codecov]

Codecov Report

Merging #585 (2300c9b) into main (a36a728) will increase coverage by 1.07%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   88.53%   89.61%   +1.07%     
==========================================
  Files           9        9              
  Lines         349      366      +17     
  Branches      123      134      +11     
==========================================
+ Hits          309      328      +19     
- Misses         37       38       +1     
+ Partials        3        0       -3     

Impacted Files	Coverage Δ
src/transform/headers.ts	25.00% <0.00%> (-2.28%)	⬇️
src/transform/index.ts	83.92% <ø> (+4.29%)	⬆️
src/transform/responses.ts	88.37% <ø> (+0.27%)	⬆️
src/transform/operation.ts	97.05% <100.00%> (+0.18%)	⬆️
src/transform/parameters.ts	97.56% <100.00%> (+0.06%)	⬆️
src/transform/schema.ts	98.68% <100.00%> (+1.62%)	⬆️
src/transform/paths.ts	92.30% <0.00%> (+0.30%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c51afc...2300c9b. Read the comment docs.

[mehalter]

Ah I forgot to run the linter, let me do that to fix this test.

[mehalter]

@drwpow updated the commit with linted code

[drwpow]

@all-contributors please add @mehalter for code, test, bug

[allcontributors]

@drwpow

I've put up a pull request to add @mehalter! 🎉

[drwpow]

Released in v3.2.4! 🎉

[radist2s]

@mehalter, @drwpow,
seems, this release broke a lot of specifications that were already working.
According to OpenAPI v 3.0.2: Consistent with JSON Schema, additionalProperties defaults to true.
At the same time, according to 3.0.1 additionalProperties is optional.

By the way with oneOf generated result could be useless with non object types:

{
  "pictures": {
    "type": "array",
    "items": {
      "oneOf": [
        {
          "type": "integer"
        },
        {
          "$ref": "#/components/schemas/ItemsArtworksPictures"
        }
      ]
    }
  }
}

{
  pictures?: ((number | components["schemas"]["ItemsArtworksPictures"]) & {
    [key: string]: any;
  })[];
}

[drwpow]

Due to feedback, we’re going to revert this behavior in 3.3.0, back to the way it was. However, you can get this behavior by opting in via the --additional-properties flag. So if you need that, simply add that flag (it’ll be a Node.js API option, too)!