-
-
Notifications
You must be signed in to change notification settings - Fork 531
handle case where additionalRef is a ref (fixes #345) #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle case where additionalRef is a ref (fixes #345) #383
Conversation
Codecov Report
@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 92.91% 93.51% +0.60%
==========================================
Files 5 5
Lines 268 262 -6
Branches 90 84 -6
==========================================
- Hits 249 245 -4
Misses 13 13
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
Not completely sure how codecov calculates coverage on my patch and what I can do to improve it, as I cannot find an easy way to run codecov patch locally? |
Yeah I personally have never benefitted much from paying attention to the patch coverage; maybe it’s a project-level setting that I need to disable. Sorry about that! But I would just ignore that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
Great, any plans for a release soon? This was kind of a deal-breaker for us, we're using a local copy based on this PR for now, but would like to get back to the original library as fast as possible. |
Yes actually |
Fixes #345
As stated in the comment, the functionality in getAdditionalPropertiesType could perhaps be added in nodeType, but then I had to pass in the rawDefinition there, and risk messing up things.
This seems to work, added a new tests based on the inut in #345, both this and all old tests pass