-
-
Notifications
You must be signed in to change notification settings - Fork 540
fix: check if path item is method operation #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New `OpenAPI3PathItem` limits possible methods Missing `servers` key added as `any` type
paths include 'summary' and 'description'
Codecov Report
@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 92.91% 92.93% +0.02%
==========================================
Files 5 5
Lines 268 269 +1
Branches 90 90
==========================================
+ Hits 249 250 +1
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍🏼
ping @drwpow for 2nd review, I'm new here :D
@all-contributors please add @rendall for code, bug, test |
I've put up a pull request to add @rendall! 🎉 |
Released in |
Fixes issue #360
isMethod
intransformPaths
in ./src/v3.tsOpenAPI3PathItemObject
type in ./src/types/OpenAPI3.tsOpenAPI3PathItemObject
is per "PathItemObject" spec https://swagger.io/specification/#path-item-objectOpenAPI3Paths
OpenAPI3PathItemObject
is missing theservers
field from the specsmethod
tofield
since it might not be a methodEdit: updated type to
OpenAPI3PathItemObject
fromOpenAPI3PathItem