Skip to content

fix(openapi-typescript): Add missing changeset for #2248 #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Apr 10, 2025

Changes

Adds changeset that should have been in #2248.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@gzm0 gzm0 requested a review from a team as a code owner April 10, 2025 07:11
@gzm0 gzm0 requested a review from drwpow April 10, 2025 07:11
Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: f7922a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 10, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f7922a2

@gzm0 gzm0 removed the request for review from drwpow April 10, 2025 07:11
@gzm0
Copy link
Contributor Author

gzm0 commented Apr 10, 2025

@backflip I'd appreciate a quick review here. Note that this might cause your contribution to be wrongly attributed to me.

If that's an issue for you, I suggest we revert #2248 and you re-open a cherry pick with a changeset.

@backflip
Copy link
Contributor

@gzm0, no worries about the attribution, thanks for asking! LGTM.

@gzm0
Copy link
Contributor Author

gzm0 commented Apr 10, 2025

Proceeding w/o maintainer review to fix main.
I consider review by @backflip sufficient in this case: Had this been on the original PR, the same pairs of eyes would have seen it.

@gzm0 gzm0 merged commit 7f3f7b6 into openapi-ts:main Apr 10, 2025
8 checks passed
@gzm0 gzm0 deleted the changeset branch April 10, 2025 08:38
@openapi-ts-bot openapi-ts-bot mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants