Increase size limit for openapi-fetch #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A recent PR increased the weight of openapi-fetch by ~0.2kb. This is all perfectly-safe, and normal, especially with handwritten code.
The size-limits check isn’t to try to get us to participate in code golf or enforce arbitrary limits. Especially in openapi-fetch’s case, the purpose is to:
For all these reasons, size-limit is NOT a required check, because it shouldn’t block PRs. But if failing, it should force follow-up PRs like this one.
How to Review
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)