Skip to content

Fix build #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix build #2031

merged 1 commit into from
Dec 2, 2024

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Dec 2, 2024

Changes

#2027 Broke the build by requiring an env var set in all contexts (it builds the docs alongside everything else). This changes the docs to use a separate build command to sidestep this issue, and removes the env var from Turborepo’s context.

How to Review

  • CI should pass
  • Cloudflare should fail; that’s OK (can be fixed after merge since that’s separate)

Checklist

N/A

@drwpow drwpow marked this pull request as ready for review December 2, 2024 22:43
@drwpow drwpow requested a review from a team as a code owner December 2, 2024 22:43
@drwpow drwpow requested a review from htunnicliff December 2, 2024 22:43
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 6.42 KB (0%)

Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2024

Deploying openapi-ts with  Cloudflare Pages  Cloudflare Pages

Latest commit: f196fe9
Status: ✅  Deploy successful!
Preview URL: https://a8462a9c.openapi-ts.pages.dev
Branch Preview URL: https://fix-build.openapi-ts.pages.dev

View logs

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: f196fe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow merged commit fc4026f into main Dec 2, 2024
9 of 10 checks passed
@drwpow drwpow deleted the fix-build branch December 2, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants