Chore: Update deps #1964
Chore: Update deps #1964
Conversation
|
Deploying openapi-ts with
|
| Latest commit: |
baabe7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d62c27db.openapi-ts.pages.dev |
| Branch Preview URL: | https://drwpow-deps.openapi-ts.pages.dev |
drwpow
force-pushed
the
drwpow/deps
branch
2 times, most recently
from
1955a1e to
fb060ed
Compare
size-limit report 📦
|
| @@ -121,7 +121,11 @@ export default function createClient<Paths extends {}, Media extends MediaType = | |||
| useQuery: (method, path, ...[init, options, queryClient]) => | |||
| useQuery(queryOptions(method, path, init as InitWithUnknowns<typeof init>, options), queryClient), | |||
| useSuspenseQuery: (method, path, ...[init, options, queryClient]) => | |||
| useSuspenseQuery(queryOptions(method, path, init as InitWithUnknowns<typeof init>, options), queryClient), | |||
| useSuspenseQuery( | |||
| // @ts-expect-error TODO: fix minor type mismatch between useQuery and useSuspenseQuery | |||
There was a problem hiding this comment.
cc @kerwanp there’s an error on the newer version of @tanstack/react-query here, but it looks like a superficial one:
Argument of type 'UseQueryOptions<Response["data"], Response["error"], Response["data"], QueryKey<Paths, Method, Path>>' is not assignable to parameter of type 'UseSuspenseQueryOptions<Response["data"], Response["error"], Response["data"], QueryKey<Paths, Method, Path>>'.
Types of property 'queryFn' are incompatible.
Type 'unique symbol | QueryFunction<Response["data"], QueryKey<Paths, Method, Path>, never> | undefined' is not assignable to type 'QueryFunction<Response["data"], QueryKey<Paths, Method, Path>, never> | undefined'.
Type 'typeof skipToken' is not assignable to type 'QueryFunction<Response["data"], QueryKey<Paths, Method, Path>, never>'.ts(2345)
I don’t think it actually affects runtime too much. And the solution may be hairy / didn’t want to destroy the inference happening. So just ignored it for now.
| @@ -65,17 +65,18 @@ | |||
| "openapi-typescript-helpers": "workspace:^" | |||
| }, | |||
| "devDependencies": { | |||
| "@tanstack/react-query": "^5.59.16", | |||
There was a problem hiding this comment.
Also we weren’t loading a specific version of @tanstack/react-query for tests, etc but we should be. Added as a devDep (users still control this package, but we still have to pin a version for our own local tests, etc.)
Changes
Updates deps to fix artificial security issues
How to Review
Checklist
N/A