fix(openapi-react-query): Fix typing of queryOptions #1952
Conversation
🦋 Changeset detectedLatest commit: bbaf5ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tests are failing because I bumped |
The tests are failing because the lockfile is out of date. Could you run |
|
Done. |
|
Thanks! This PR looks great, and the tests seem to be passing. Could you add a |
- Adds `NoInfer` to function return type because starting from
TypeScript 5.5 it can affect inference. For example:
const f = <T,>(x: NoInfer<T>) => x;
const x: number = f('foo');
^^^^^ expects number
Previous versions could not infer `T` and complained about something
like "unknown cannot be assigned to number".
This error is not reproducible with `paths` so we test against a
minimal paths type.
- Excludes `SkipToken` (introduced in v5.25) from `queryFn` to be
compatible with `useSuspenseQuery`.
|
Added changeset. |
|
It should also fix #1946, I just messed up the syntax. Could you please close that? |
Oh yes good catch! I personally can never get the syntax right for closing multiple issues |
- Adds `NoInfer` to function return type because starting from
TypeScript 5.5 it can affect inference. For example:
const f = <T,>(x: NoInfer<T>) => x;
const x: number = f('foo');
^^^^^ expects number
Previous versions could not infer `T` and complained about something
like "unknown cannot be assigned to number".
This error is not reproducible with `paths` so we test against a
minimal paths type.
- Excludes `SkipToken` (introduced in v5.25) from `queryFn` to be
compatible with `useSuspenseQuery`.
Changes
Fixes #1929, #1946. And also fixes an issue with
SkipTokenanduseSuspenseQuery.How to Review
Added tests that reproduce the bug so if they are correct and green, the linked issues should be fixed.
Checklist