Skip to content

fix(openapi-typescript-helpers): fix SuccessResponseJSON, ErrorResponseJSON and RequestBodyJSON #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

piousdeer
Copy link
Contributor

Changes

Since #1871,

  1. SuccessResponseJSON and ErrorResponseJSON no longer return never, but may return a non-application/json response.
  2. RequestBodyJSON returns { "application/json": T } instead of T.

This fixes these issues.

How to Review

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@piousdeer piousdeer requested a review from a team as a code owner October 14, 2024 16:28
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: d71272b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
openapi-typescript-helpers Patch
openapi-fetch Patch
openapi-react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks!

@drwpow drwpow merged commit abfad56 into openapi-ts:main Oct 25, 2024
8 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants